Merge pull request splitrb#241 from swrobel/metrics-on-dashboard

Metrics on dashboard

Author: Andrew Nesbitt

lib/split/dashboard.rb

@@ -17,6 +17,9 @@ class Dashboard < Sinatra::Base
     get '/' do
       # Display experiments without a winner at the top of the dashboard
       @experiments = Split::Experiment.all_active_first
+
+      @metrics = Split::Metric.all
+
       # Display Rails Environment mode (or Rack version if not using Rails)
       if Object.const_defined?('Rails')
         @current_env = Rails.env.titlecase

lib/split/dashboard/views/_experiment.erb

@@ -9,6 +9,10 @@
       Experiment: <%= experiment.name %>
       <% if experiment.version > 1 %><span class='version'>v<%= experiment.version %></span><% end %>
       <% unless goal.nil? %><span class='goal'>Goal:<%= goal %></span><% end %>
+      <% metrics = @metrics.select {|metric| metric.experiments.include? experiment} %>
+      <% unless metrics.empty? %>
+        <span class='goal'>Metrics:<%= metrics.map(&:name).join(', ') %></span>
+      <% end %>
     </h2>
 
     <% if goal.nil? %>

lib/split/metric.rb

@@ -42,6 +42,25 @@ def self.find(name)
       metric
     end
 
+    def self.find_or_create(attrs)
+      metric = find(attrs[:name])
+      unless metric
+        metric = new(attrs)
+        metric.save
+      end
+      metric
+    end
+
+    def self.all
+      redis_metrics = Split.redis.hgetall(:metrics).collect do |key, value|
+        find(key)
+      end
+      configuration_metrics = Split.configuration.metrics.collect do |key, value|
+        new(name: key, experiments: value)
+      end
+      redis_metrics | configuration_metrics
+    end
+
     def self.possible_experiments(metric_name)
       experiments = []
       metric  = Split::Metric.find(metric_name)
@@ -78,4 +97,4 @@ def self.normalize_metric(label)
       return metric_name, goals
     end
   end
-end
+end

spec/dashboard_spec.rb

@@ -21,6 +21,10 @@ def link(color)
     Split::Experiment.find_or_create({"link_color" => ["goal_1", "goal_2"]}, "blue", "red")
   }
 
+  let(:metric) {
+    Split::Metric.find_or_create(name: 'testmetric', experiments: [experiment, experiment_with_goals])
+  }
+
   let(:red_link) { link("red") }
   let(:blue_link) { link("blue") }
 
@@ -43,6 +47,15 @@ def link(color)
         post "/start/#{experiment.name}"
         get '/'
         last_response.body.should include('Reset Data')
+        last_response.body.should_not include('Metrics:')
+      end
+    end
+
+    context "experiment with metrics" do
+      it "should display the names of associated metrics" do
+        metric
+        get '/'
+        last_response.body.should include('Metrics:testmetric')
       end
     end