Update to latest hexo version, node 14.0.0 minimum required (fix #533) #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI I tested with node v22.3.0. |
|
I guess we don't really use the hexo-deployer-git plugin, but custom commands, see |
|
I guess we wait to update the robot as well supermedium/a-frobot#2 before merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #533
The github version of hexo-renderer-marked we used was for this PR that was merged hexojs/hexo-renderer-marked#24 so latest version include the lowercase anchors.
sanitize and tables options are deprecated, sanitize was false, and tables is now included with gfm option, see
https://github.com/hexojs/hexo-renderer-marked/releases/tag/2.0.0
hexo-generator-feed I kept it to 1.2.0, I tested more recent version but got an error.
I tested the feed is correctly rendered when I go to http://localhost:4000/feed.xml
hexo-filter-github-emojis I pinned the version to 1.4.4. I didn't test more recent version.
All the other plugins are the latest version.
Reading https://hexo.io/docs/one-command-deployment#Git the deploy key is repo, not repository.
I read all the changelogs and README, I didn't see any other breaking change worth mentioning for our use here.