fix: resolve all remaining golangci-lint errors

agb-cloud · claude · agb-cloud · commit ef24097a14b1 · 2025-10-13T22:24:17.000+08:00
Comprehensive fix for all linter issues:
- errcheck: Add error handling for w.Write(), json.Encoder.Encode(), and io.Copy() in test files
- gosimple S1034: Use type switch instead of repeated type assertions in setBody()
- staticcheck SA9003: Remove empty branch by using early returns in detectContentType()

All test mock servers now properly ignore write errors with _ assignments and comments.

🤖 Generated with [Claude Code]

Co-Authored-By: Claude &lt;noreply@anthropic.com&gt;
diff --git a/internal/client/client.go b/internal/client/client.go
@@ -245,16 +245,19 @@ func setBody(body interface{}, contentType string) (bodyBuf *bytes.Buffer, err e
 		bodyBuf = &bytes.Buffer{}
 	}
 
-	if reader, ok := body.(io.Reader); ok {
-		_, err = bodyBuf.ReadFrom(reader)
-	} else if b, ok := body.([]byte); ok {
-		_, err = bodyBuf.Write(b)
-	} else if s, ok := body.(string); ok {
-		_, err = bodyBuf.WriteString(s)
-	} else if s, ok := body.(*string); ok {
-		_, err = bodyBuf.WriteString(*s)
-	} else if JsonCheck.MatchString(contentType) {
-		err = json.NewEncoder(bodyBuf).Encode(body)
+	switch v := body.(type) {
+	case io.Reader:
+		_, err = bodyBuf.ReadFrom(v)
+	case []byte:
+		_, err = bodyBuf.Write(v)
+	case string:
+		_, err = bodyBuf.WriteString(v)
+	case *string:
+		_, err = bodyBuf.WriteString(*v)
+	default:
+		if JsonCheck.MatchString(contentType) {
+			err = json.NewEncoder(bodyBuf).Encode(body)
+		}
 	}
 
 	if err != nil {
@@ -270,20 +273,17 @@ func setBody(body interface{}, contentType string) (bodyBuf *bytes.Buffer, err e
 
 // detectContentType method is used to figure out `Request.Body` content type for request header
 func detectContentType(body interface{}) string {
-	contentType := "text/plain; charset=utf-8"
-	switch body.(type) {
+	switch v := body.(type) {
 	case string:
-		// Already set to text/plain by default, no need to reassign
+		return "text/plain; charset=utf-8"
 	case []byte:
-		contentType = http.DetectContentType(body.([]byte))
+		return http.DetectContentType(v)
 	case map[string]interface{}, []interface{}:
-		contentType = "application/json; charset=utf-8"
+		return "application/json; charset=utf-8"
 	default:
 		// For any other type, assume JSON
-		contentType = "application/json; charset=utf-8"
+		return "application/json; charset=utf-8"
 	}
-
-	return contentType
 }
 
 // GenericOpenAPIError Provides access to the body, error and model on returned errors.
diff --git a/test/integration/login_port_selection_integration_test.go b/test/integration/login_port_selection_integration_test.go
@@ -77,7 +77,7 @@ func TestLoginPortSelectionIntegration(t *testing.T) {
 					}`, tt.mockAlternativePorts)
 					w.Header().Set("Content-Type", "application/json")
 					w.WriteHeader(http.StatusOK)
-					w.Write([]byte(response))
+					_, _ = w.Write([]byte(response)) // Ignore errors in test mock server
 				} else if strings.Contains(r.URL.Path, "login_translate") {
 					response := `{
 						"code": "200",
@@ -94,7 +94,7 @@ func TestLoginPortSelectionIntegration(t *testing.T) {
 					}`
 					w.Header().Set("Content-Type", "application/json")
 					w.WriteHeader(http.StatusOK)
-					w.Write([]byte(response))
+					_, _ = w.Write([]byte(response)) // Ignore errors in test mock server
 				}
 			}))
 			defer mockServer.Close()
diff --git a/test/unit/image_api_test.go b/test/unit/image_api_test.go
@@ -54,7 +54,7 @@ func TestImageAPIGetUploadCredential(t *testing.T) {
 		}
 
 		w.Header().Set("Content-Type", "application/json")
-		json.NewEncoder(w).Encode(response)
+		_ = json.NewEncoder(w).Encode(response) // Ignore errors in test mock server
 	}))
 	defer server.Close()
 
@@ -154,7 +154,7 @@ func TestImageAPICreateImage(t *testing.T) {
 		}
 
 		w.Header().Set("Content-Type", "application/json")
-		json.NewEncoder(w).Encode(response)
+		_ = json.NewEncoder(w).Encode(response) // Ignore errors in test mock server
 	}))
 	defer server.Close()
 
@@ -309,7 +309,7 @@ func TestImageAPIGetImageTask(t *testing.T) {
 		}
 
 		w.Header().Set("Content-Type", "application/json")
-		json.NewEncoder(w).Encode(response)
+		_ = json.NewEncoder(w).Encode(response) // Ignore errors in test mock server
 	}))
 	defer server.Close()
 
@@ -428,7 +428,7 @@ func TestImageAPIListImages(t *testing.T) {
 		}
 
 		w.Header().Set("Content-Type", "application/json")
-		json.NewEncoder(w).Encode(response)
+		_ = json.NewEncoder(w).Encode(response) // Ignore errors in test mock server
 	}))
 	defer server.Close()
 
@@ -599,7 +599,7 @@ func TestImageAPIService_StartImage(t *testing.T) {
 
 			w.Header().Set("Content-Type", "application/json")
 			w.WriteHeader(http.StatusOK)
-			json.NewEncoder(w).Encode(response)
+			_ = json.NewEncoder(w).Encode(response) // Ignore errors in test mock server
 		}))
 		defer server.Close()
 
@@ -653,7 +653,7 @@ func TestImageAPIService_StartImage(t *testing.T) {
 
 			w.Header().Set("Content-Type", "application/json")
 			w.WriteHeader(http.StatusOK)
-			json.NewEncoder(w).Encode(response)
+			_ = json.NewEncoder(w).Encode(response) // Ignore errors in test mock server
 		}))
 		defer server.Close()
 
@@ -720,7 +720,7 @@ func TestImageAPIService_StartImage(t *testing.T) {
 
 			w.Header().Set("Content-Type", "application/json")
 			w.WriteHeader(http.StatusBadRequest)
-			json.NewEncoder(w).Encode(response)
+			_ = json.NewEncoder(w).Encode(response) // Ignore errors in test mock server
 		}))
 		defer server.Close()
 
@@ -795,7 +795,7 @@ func TestImageAPIService_StopImage(t *testing.T) {
 
 			w.Header().Set("Content-Type", "application/json")
 			w.WriteHeader(http.StatusOK)
-			json.NewEncoder(w).Encode(response)
+			_ = json.NewEncoder(w).Encode(response) // Ignore errors in test mock server
 		}))
 		defer server.Close()
 
@@ -866,7 +866,7 @@ func TestImageAPIService_StopImage(t *testing.T) {
 
 			w.Header().Set("Content-Type", "application/json")
 			w.WriteHeader(http.StatusBadRequest)
-			json.NewEncoder(w).Encode(response)
+			_ = json.NewEncoder(w).Encode(response) // Ignore errors in test mock server
 		}))
 		defer server.Close()
 
diff --git a/test/unit/login_port_selection_test.go b/test/unit/login_port_selection_test.go
@@ -74,7 +74,7 @@ func TestLoginPortSelectionFlow(t *testing.T) {
 				}`
 				w.Header().Set("Content-Type", "application/json")
 				w.WriteHeader(http.StatusOK)
-				w.Write([]byte(response))
+				_, _ = w.Write([]byte(response)) // Ignore errors in test mock server
 			}))
 			defer server.Close()
 
@@ -157,7 +157,7 @@ func TestLoginTranslateWithSelectedPort(t *testing.T) {
 		}`
 		w.Header().Set("Content-Type", "application/json")
 		w.WriteHeader(http.StatusOK)
-		w.Write([]byte(response))
+		_, _ = w.Write([]byte(response)) // Ignore errors in test mock server
 	}))
 	defer server.Close()
 
diff --git a/test/unit/login_test.go b/test/unit/login_test.go
@@ -64,7 +64,7 @@ func TestLoginCommand(t *testing.T) {
 
 		w.Header().Set("Content-Type", "application/json")
 		w.WriteHeader(http.StatusOK)
-		json.NewEncoder(w).Encode(response)
+		_ = json.NewEncoder(w).Encode(response) // Ignore errors in test mock server
 	}))
 	defer mockServer.Close()
 
@@ -199,7 +199,7 @@ func TestLoginCommandErrorHandling(t *testing.T) {
 	// Create a mock server that returns an error
 	mockServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(http.StatusInternalServerError)
-		w.Write([]byte("Internal Server Error"))
+		_, _ = w.Write([]byte("Internal Server Error")) // Ignore errors in test mock server
 	}))
 	defer mockServer.Close()
 
diff --git a/test/unit/logout_cmd_simple_test.go b/test/unit/logout_cmd_simple_test.go
@@ -126,7 +126,7 @@ func TestLogoutCommandSimple(t *testing.T) {
 			// Restore stdout and get output
 			w.Close()
 			os.Stdout = oldStdout
-			io.Copy(&buf, r)
+			_, _ = io.Copy(&buf, r) // Ignore errors in test helper
 			output := buf.String()
 
 			if err != nil {
@@ -184,7 +184,7 @@ func TestLogoutCommandNoConfig(t *testing.T) {
 	// Restore stdout and get output
 	w.Close()
 	os.Stdout = oldStdout
-	io.Copy(&buf, r)
+	_, _ = io.Copy(&buf, r) // Ignore errors in test helper
 	output := buf.String()
 
 	if err != nil {
diff --git a/test/unit/logout_test.go b/test/unit/logout_test.go
@@ -96,7 +96,7 @@ func TestLogout(t *testing.T) {
 				// Return mock response
 				w.Header().Set("Content-Type", "application/json")
 				w.WriteHeader(tt.mockStatusCode)
-				json.NewEncoder(w).Encode(tt.mockResponse)
+				_ = json.NewEncoder(w).Encode(tt.mockResponse) // Ignore errors in test mock server
 			}))
 			defer mockServer.Close()
 
diff --git a/test/unit/oauth_test.go b/test/unit/oauth_test.go
@@ -63,7 +63,7 @@ func TestOAuthAPI_GetLoginProviderURL_WithLocalhostPort(t *testing.T) {
 				}`
 				w.Header().Set("Content-Type", "application/json")
 				w.WriteHeader(http.StatusOK)
-				w.Write([]byte(response))
+				_, _ = w.Write([]byte(response)) // Ignore errors in test mock server
 			}))
 			defer server.Close()
 
@@ -156,7 +156,7 @@ func TestOAuthAPI_LoginTranslate_WithLocalhostPort(t *testing.T) {
 				}`
 				w.Header().Set("Content-Type", "application/json")
 				w.WriteHeader(http.StatusOK)
-				w.Write([]byte(response))
+				_, _ = w.Write([]byte(response)) // Ignore errors in test mock server
 			}))
 			defer server.Close()
 
@@ -218,7 +218,7 @@ func TestOAuthLoginProviderResponse_AlternativePorts(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.Header().Set("Content-Type", "application/json")
 		w.WriteHeader(http.StatusOK)
-		w.Write([]byte(jsonResponse))
+		_, _ = w.Write([]byte(jsonResponse)) // Ignore errors in test mock server
 	}))
 	defer server.Close()
 
diff --git a/test/unit/retry_test.go b/test/unit/retry_test.go
@@ -26,7 +26,7 @@ func TestRetryMechanism(t *testing.T) {
 				return func(w http.ResponseWriter, r *http.Request) {
 					*attemptCount++
 					w.WriteHeader(http.StatusOK)
-					w.Write([]byte("success"))
+					_, _ = w.Write([]byte("success")) // Ignore errors in test mock server
 				}
 			},
 			expectedAttempts: 1,
@@ -41,11 +41,11 @@ func TestRetryMechanism(t *testing.T) {
 					if *attemptCount == 1 {
 						// Simulate server error on first attempt (retryable)
 						w.WriteHeader(http.StatusInternalServerError)
-						w.Write([]byte("server error"))
+						_, _ = w.Write([]byte("server error")) // Ignore errors in test mock server
 						return
 					}
 					w.WriteHeader(http.StatusOK)
-					w.Write([]byte("success"))
+					_, _ = w.Write([]byte("success")) // Ignore errors in test mock server
 				}
 			},
 			expectedAttempts: 2,
@@ -59,11 +59,11 @@ func TestRetryMechanism(t *testing.T) {
 					*attemptCount++
 					if *attemptCount <= 2 {
 						w.WriteHeader(http.StatusInternalServerError)
-						w.Write([]byte("server error"))
+						_, _ = w.Write([]byte("server error")) // Ignore errors in test mock server
 						return
 					}
 					w.WriteHeader(http.StatusOK)
-					w.Write([]byte("success"))
+					_, _ = w.Write([]byte("success")) // Ignore errors in test mock server
 				}
 			},
 			expectedAttempts: 3,
@@ -76,7 +76,7 @@ func TestRetryMechanism(t *testing.T) {
 				return func(w http.ResponseWriter, r *http.Request) {
 					*attemptCount++
 					w.WriteHeader(http.StatusNotFound)
-					w.Write([]byte("not found"))
+					_, _ = w.Write([]byte("not found")) // Ignore errors in test mock server
 				}
 			},
 			expectedAttempts: 1,
