Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user_memberships_query sometimes returns [None] #654

Open
agdsn-sentry bot opened this issue Aug 2, 2023 · 1 comment
Open

user_memberships_query sometimes returns [None] #654

agdsn-sentry bot opened this issue Aug 2, 2023 · 1 comment
Labels
bug 🔨 lib Things relating to the core logic / functionality 🔨 web/ui Things relating to Flask routes and Jinja templates

Comments

@agdsn-sentry
Copy link

agdsn-sentry bot commented Aug 2, 2023

Sentry Issue: PYCROFT-5N

ValidationError: 1 validation error for MembershipRow
denies.0
  Input should be a valid string [type=string_type, input_value=None, input_type=NoneType]
    For further information visit https://errors.pydantic.dev/2.0.3/v/string_type
(2 additional frame(s) were not displayed)
...
  File "__init__.py", line 298, in error_router
    return original_handler(e)
  File "flask/app.py", line 1516, in full_dispatch_request
    rv = self.dispatch_request()
  File "flask/app.py", line 1502, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
  File "web/blueprints/user/__init__.py", line 459, in user_show_groups_json
    items=[
  File "web/blueprints/user/__init__.py", line 460, in <listcomp>
    MembershipRow(
lukasjuhrich added a commit that referenced this issue Aug 2, 2023
contains a hotfix for #654
@lukasjuhrich
Copy link
Collaborator

f51c1fc was a workaround, the proper fix would fix the query (so that it does not return [None] when nothing is denied)

@lukasjuhrich lukasjuhrich added bug 🔨 lib Things relating to the core logic / functionality 🔨 web/ui Things relating to Flask routes and Jinja templates labels Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🔨 lib Things relating to the core logic / functionality 🔨 web/ui Things relating to Flask routes and Jinja templates
Projects
None yet
Development

No branches or pull requests

1 participant