UserTask log entries shown on the wrong user

[ibot3]

Currently, the task logs are shown in the log table of the author of the tasks.
However, this is not intended, as the task logs should be shown in the log table of the target user.

I am not sure, but maybe the relationship is inconsistent.
The relationship on TaskLogEntry side seems to be correct:

pycroft/pycroft/model/logging.py

Lines 57 to 62 in f25dc1f

	user: Mapped[User] = relationship(
	primaryjoin="TaskLogEntry.task_id == UserTask.id",
	secondary="user_task",
	back_populates="task_log_entries",
	viewonly=True,
	)

But on the user site, the join condition is missing:

pycroft/pycroft/model/user.py

Lines 249 to 251 in f25dc1f

	task_log_entries: Mapped[list[TaskLogEntry]] = relationship(
	back_populates="user", viewonly=True
	)

SQLA maybe does a relationship with the author instead because of that?
(Commit a7efe20#diff-8d7fe1e2c7af484e9b87c16b9981b631d191918ca6886c1c17cb3c2b08546afd)

Another bug I noticed: Opening the tab for just the task logs shows error 404

[lukasjuhrich]

The latter thing is a typo:

pycroft/web/blueprints/helpers/log_tables.py

Lines 52 to 57 in f25dc1f

	LogType = t.Literal["user", "room", "hades", "task", "all"]
	LOG_TYPES = frozenset(t.get_args(LogType))
	def is_log_type(type: str) -> t.TypeGuard[LogType]:
	return type in LOG_TYPES

pycroft/web/blueprints/user/__init__.py

Line 341 in f25dc1f

log_table_tasks=LogTableSpecific(data_url=_log_endpoint(logtype="tasks")),

[lukasjuhrich]

Regarding the first thing, the question would be why user.task_log_entries does not contain those log entries which refer to the user, right? so a test skeleton might be something like

def test_user_backref_task_log_entries(session, user, processor):
    session.add(task := UserTask(
        creator=processor,
        user=user,
        # … (other attributes)
    ))
    session.add(le := TaskLogentry(message="foo", task=task, author=processor))
    session.flush()
    assert le.user == user
    assert user.task_log_entries == [le]

…correct?

[ibot3]

Correct AFAICS.