New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account not marked as legacy #740

Open

2 tasks

lukasjuhrich opened this issue Jul 11, 2024 · 1 comment

Labels

bug easy task 🔨 web/ui

Collaborator

lukasjuhrich commented Jul 11, 2024 •

edited

Loading

I've stumbled across this piece of code, which most likely is a bug:

pycroft/web/blueprints/finance/__init__.py

Lines 788 to 795 in 865ebcf

    
           account = session.get(Account, account_id) 
        
           if not account: 
        
               abort(404) 
        
           account.legacy = not account.legacy 
        
           session.commit()

it's missing a session.add(account).

Add a test witnessing this bug
make it pass :)

The text was updated successfully, but these errors were encountered:

lukasjuhrich added bug 🔨 web/ui easy task labels

Member

ibot3 commented Aug 2, 2024

Since when is it required to call session.add on existing objects?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment