Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username normalization on login #430

Open
Paktosan opened this issue Oct 1, 2021 · 2 comments
Open

Username normalization on login #430

Paktosan opened this issue Oct 1, 2021 · 2 comments

Comments

@Paktosan
Copy link
Member

Paktosan commented Oct 1, 2021

Some users try to set a username with capital letters during registration.
When they try to login into SIPA, they get "Wrong credentials" because they did not write their login in lower case letters.
I would propose that we set every letter lower case before checking the login.

@ibot3
Copy link
Member

ibot3 commented Oct 2, 2021

Cannot reproduce.

@ibot3 ibot3 added the invalid label Oct 2, 2021
@lukasjuhrich
Copy link
Collaborator

lukasjuhrich commented Oct 2, 2021

@ibot3 Please provide more information.
Do you mean to imply that the sipa login already is case-insensitive? Because skimming through the code, we nowhere issue a call to .lower().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants