Skip to content

Fix zai coding plan delegates #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikehostetler merged 3 commits into from
Jan 30, 2026
+44 −4
Merged

Fix zai coding plan delegates #352

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53c9f97
Add missing defdelegate for zai_coding_plan
dbii Jan 22, 2026
c1cfc55
Skip defdelegate and put in code instead
dbii Jan 22, 2026
6ed8ad4
Merge branch 'main' into fix-zai-coding-plan-delegates
mikehostetler Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 44 additions & 4 deletions lib/req_llm/providers/zai_coding_plan.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,44 @@ defmodule ReqLLM.Providers.ZaiCodingPlan do
default_base_url: "https://api.z.ai/api/coding/paas/v4",
default_env_key: "ZAI_API_KEY"

# Delegate all callbacks to ReqLLM.Providers.ZaiCoder
defdelegate prepare_request(operation, model_spec, input, opts),
to: ReqLLM.Providers.ZaiCoder
@provider_schema [
thinking: [
type: :map,
doc:
~s(Control thinking/reasoning mode. Set to %{type: "disabled"} to disable or %{type: "enabled"} to enable.)
]
]

defdelegate attach(request, model_input, user_opts), to: ReqLLM.Providers.ZaiCoder
# Delegate all callbacks to ReqLLM.Providers.ZaiCoder
@impl ReqLLM.Provider
def prepare_request(operation, model_spec, input, opts) do
ReqLLM.Provider.Defaults.prepare_request(__MODULE__, operation, model_spec, input, opts)
end

@impl ReqLLM.Provider
def attach(request, model_input, user_opts) do
context = Map.get(request.options, :context)

default_timeout =
if context && Map.get(context, :__thinking_mode__, false) do
Application.get_env(:req_llm, :thinking_timeout, 300_000)
else
Application.get_env(:req_llm, :receive_timeout, 120_000)
end

timeout = Keyword.get(user_opts, :receive_timeout, default_timeout)

updated_request =
request
|> Map.update!(:options, fn opts ->
opts
|> Map.put(:receive_timeout, timeout)
|> Map.put(:pool_timeout, timeout)
|> Map.put(:connect_options, timeout: timeout)
end)

ReqLLM.Provider.Defaults.default_attach(__MODULE__, updated_request, model_input, user_opts)
end

defdelegate encode_body(request), to: ReqLLM.Providers.ZaiCoder

Expand All @@ -58,4 +91,11 @@ defmodule ReqLLM.Providers.ZaiCodingPlan do
defdelegate translate_options(operation, model, opts), to: ReqLLM.Providers.ZaiCoder

defdelegate extract_usage(data, model), to: ReqLLM.Providers.ZaiCoder

@impl ReqLLM.Provider
def attach_stream(model, context, opts, finch_name) do
ReqLLM.Provider.Defaults.default_attach_stream(__MODULE__, model, context, opts, finch_name)
end

defdelegate decode_stream_event(event, model), to: ReqLLM.Providers.ZaiCoder
end