You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the contribution! However, I'm going to hold off on merging this for now:
Finch streaming not supported - The :req_plugins option only works for non-streaming operations. Streaming uses Finch directly via attach_stream/4, so plugins wouldn't apply there. This creates an inconsistent API surface.
Moving away from Req - We're planning to move away from Req in the future, which would make this feature short-lived and potentially a breaking change down the road.
I appreciate the effort here, but given these concerns I don't think this is the right addition at this time.
Thanks for the contribution! However, I'm going to hold off on merging this for now:
1. **Finch streaming not supported** - The `:req_plugins` option only works for non-streaming operations. Streaming uses Finch directly via `attach_stream/4`, so plugins wouldn't apply there. This creates an inconsistent API surface.
2. **Moving away from Req** - We're planning to move away from Req in the future, which would make this feature short-lived and potentially a breaking change down the road.
I appreciate the effort here, but given these concerns I don't think this is the right addition at this time.
Aha! Good to know, that you are planning that! Thanks for the input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows setting up Req Plugins on High-level api
Type of Change
Breaking Changes
Testing
mix test)mix quality)Checklist
CHANGELOG.md(it is auto-generated by git_ops)Related Issues
Closes #359