-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load from CSV #128
Comments
There are a number of cases that should probably be handled:
Currently we can handle the first and third cases. The second should not be too difficult, and if that is working both of the fourth case become essentially analogous. This probably should happen when we build a list of intervals, rather than being something that the One major change that I am making is to explicitly require a We still need to think about the possible things in an
|
Simplifying and extending `from_csv`. Initial test uses `np.genfromtext` internally. Explicitly expects to be told which columns the `top`, `base` and/or `thickness` are in. Other columns will be added to a dictionary from which the intervals will be created. Addresses, but does not entirely close #128
https://gist.github.com/mtb-za/3f94ffc426e804e7b2c778c2f0c6f051 has a couple of approaches, one using If we want to get input as something other than strings using either base approach, we need to cast them. We can start with the most specific type: |
* Update striplog.py Simplifying and extending `from_csv`. Initial test uses `np.genfromtext` internally. Explicitly expects to be told which columns the `top`, `base` and/or `thickness` are in. Other columns will be added to a dictionary from which the intervals will be created. Addresses, but does not entirely close #128 * Update `from_csv` Expanded docs. The will need to be restyled to match the rest of the library, but this will work for now. Added a series of FutureWarnings for args that we want to remove going forward. Added some new args. * Updated `from_csv` Updated docs and args to be the same. Changed version for deprecation to 0.9.1. * Updated test suite Changed tests to use new `from_csv` method. The tests were passing in strings. These no need to be explicitly converted to `io.StringIO` objects, along with the `names=True`. * Updated `from_csv()` Removed extra args. These are not currently being used, but we might want them later. No need for them for now. * Remove old `from_csv` Removed old `from_csv` function - it is no longer being used anyway.
Needs improving. For example:
The text was updated successfully, but these errors were encountered: