Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What exactly is supposed to happen?! #179

Closed
smileBeda opened this issue May 27, 2024 · 12 comments
Closed

What exactly is supposed to happen?! #179

smileBeda opened this issue May 27, 2024 · 12 comments

Comments

@smileBeda
Copy link

smileBeda commented May 27, 2024

I seem confused as of what the reminder command actually is suppose to do.

  1. I set a reminder following the syntax /reminder (what) (when)
  2. This adds the reminder tag and also a follow up comment by bot ==> OK
  3. Nothing ever happens after that ==> NOK

I would expect to actually be reminded about the issue, at the given time, by email, or whatever - IPoAC or else is fine with me too. But a reminder should remind me!

Do I misunderstand the tool? If this just adds the tag and comment, it is not very useful, I can do that myself.

@stdavis
Copy link
Member

stdavis commented May 28, 2024

Did you implement the companion action in your repo?

@smileBeda
Copy link
Author

I have two workflows:

  • scheduled.yml
name: Scheduled Events

on:
  schedule:
    - cron: "0 * * * *"
  workflow_dispatch:

permissions:
  issues: write

jobs:
  reminder:
    name: Notify
    runs-on: ubuntu-latest

    steps:
    - name: ⚠️ Notify
      uses: agrc/reminder-action@v1
  • issue_comment.yml
name: Issue Comment Events

on:
  issue_comment:
    types: [created, edited]

jobs:
  reminder:
    name: Check for reminder
    runs-on: ubuntu-latest

    steps:
      - name: 🔍 Check for reminder
        uses: agrc/create-reminder-action@v1

So I think yes?

And I can see the actions running, and succeeding.

Again.. what exactly is supposed to happen?

  1. I comment with /reminder (what) (when)
  2. It creates a new comment with contents like @username set a reminder for 6/27/2024
  3. ... ? Nothing happens ever, other than the tag reminder gets removed, as I noted, once the date expires, but I get no email, no new comment, zero nada zilch.

Can you let me know what should happen?

@stdavis
Copy link
Member

stdavis commented May 29, 2024

Here's an example of what should happen:
image

I'd be interested in taking a look at the logs for scheduled events the first time it runs after your reminder time.

@stdavis
Copy link
Member

stdavis commented Jul 5, 2024

@smileBeda Did you ever get this working?

@smileBeda
Copy link
Author

smileBeda commented Jul 6, 2024

Sorry for not replying earlier. Indeed I did suddenly get a reminder I had set the way you show in your screenshot (apart of the @ which was set to to in my case but I still got the mail and saw the comment)

I've then set another reminder to see if it would work and it didn't.
I can't understand why one works and the other not, it seems randomly applying.

When you say looking at the logs - you mean action logs? The repo is private so probably I couldn't have you look directly at it, but they actually seem all fine so far, I can't see any errors.

@stdavis
Copy link
Member

stdavis commented Jul 8, 2024

Yes, the action logs for both the agrc/reminder-action and agrc/create-reminder-action would be helpful in diagnosing your issue. Examples of your comments would be helpful as well. Perhaps you could reproduce your issue in a public repository so that we can take a look at it?

@smileBeda
Copy link
Author

/reminder To provide public example of this issue, if replicable, in 1 Month

@steveoh
Copy link
Member

steveoh commented Jul 12, 2024

/reminder To provide public example of this issue, if replicable, in 1 Month

You used the wrong trigger slash command here. What are you wanting to do and why?

@smileBeda
Copy link
Author

Well I guess that is what is the issue then? I am 100% sure I copy pasted that command from the readme at some point, also see my opening comment, I use the same reference to /reminder
Yet, I see in the readme it is /remind me [what] [when]

And I guess that is what's going on, somehow I interchange reminder with remind.

So again, I will set myself a reminder here to come back, if its not solved on my own projects, in a mont.
/remind me to provide details for replicable issue in 1 month

Copy link

@smileBeda set a reminder for 8/12/2024

Copy link

👋 @smileBeda, provide details for replicable issue

@github-actions github-actions bot removed the reminder label Aug 12, 2024
@smileBeda
Copy link
Author

Well, here we go - this reminder worked, and so did 2 more in my own repo since.
I guess we can close this, I do not know what changed, but it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants