ENUM name is not correct for first entry

[bvanelli]

Things to check first

• I have searched the existing issues and didn't find my bug already reported there

• I have checked that my bug is still present in the latest release

Sqlacodegen version

3.0.0rc5

SQLAlchemy version

2.0.37

RDBMS vendor

PostgreSQL

What happened?

SQLACodegen causes the first element of the enum to be the enum name, but as far as I know this would be taken literally as an enum value (name goes at the end with the kwarg name, which is also being done). Here are the docs for the PostgresSQL ENUM type.

I'm willing to submit a fix if this is a bug.

Database schema for reproducing the bug

Input:

CREATE SCHEMA definitions;

create type definitions.colors as ENUM
(
    'RED',
    'GREEN',
    'BLUE'
);

CREATE TABLE definitions.state (
    id UUID PRIMARY KEY,
    location TEXT,
    color definitions.colors DEFAULT 'RED'::definitions.colors
);

Output:

from typing import Optional

from sqlalchemy import PrimaryKeyConstraint, Text, Uuid, text
from sqlalchemy.dialects.postgresql import ENUM
from sqlalchemy.orm import DeclarativeBase, Mapped, mapped_column
import uuid

class Base(DeclarativeBase):
    pass


class State(Base):
    __tablename__ = 'state'
    __table_args__ = (
        PrimaryKeyConstraint('id', name='state_pkey'),
        {'schema': 'definitions'}
    )

    id: Mapped[uuid.UUID] = mapped_column(Uuid, primary_key=True)
    location: Mapped[Optional[str]] = mapped_column(Text)
    color: Mapped[Optional[str]] = mapped_column(ENUM('colors', 'RED', 'GREEN', 'BLUE', name='colors'), server_default=text("'RED'::definitions.colors"))

[sheinbergon]

@agronholm this should be an easy fix

[agronholm]

There's a test (test_fancy_coltypes) that tests this but only for plain Tables. There is no equivalent test for declarative classes.