Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsubscribe: Triggers a second unsubscribe via _eventRequest #316

Open
nic-camera opened this issue Mar 4, 2024 · 0 comments
Open

Unsubscribe: Triggers a second unsubscribe via _eventRequest #316

nic-camera opened this issue Mar 4, 2024 · 0 comments

Comments

@nic-camera
Copy link

https://github.com/agsh/onvif/blob/768bc8b4220a31c1813c3e78355e45e8a6826605/lib/events.js

When calling Cam.prototype.unsubscribe, a second unsubscribe is then soon triggered that passes no event data.
This second call originates from Cam.prototype._eventRequest and passes no callback method, so the
throw new Error('You should create pull-point subscription first!')
goes unhandled, as the call in eventRequest is not in a try/catch.

I am not sure why this second call to unsubscribe is triggered, as part of the unsubscribe flow, and have not been able to correctly handle the error that is thrown as result of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant