Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quat_feat implementation #33

Open
gnool opened this issue Jul 9, 2023 · 0 comments
Open

quat_feat implementation #33

gnool opened this issue Jul 9, 2023 · 0 comments

Comments

@gnool
Copy link

gnool commented Jul 9, 2023

@ahmedosman
in the quat_feat function, in the line
quat = torch.cat([v_sin * normalized,v_cos-1], dim=1)

is the -1 intentional? The comment says it should return a normalized quaternion but this -1 seems to make it non-normalized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gnool