Skip to content

Commit 8ea648b

Browse files
authored
Merge pull request kubernetes#2985 from chrislovecnm/api-server-cleanup
versioning kops-server container, and changing container
2 parents 871c10d + afdf003 commit 8ea648b

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

Makefile

+2-1
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ endif
6060
# + is valid in semver, but not in docker tags. Fixup CI versions.
6161
# Note that this mirrors the logic in DefaultProtokubeImageName
6262
PROTOKUBE_TAG := $(subst +,-,${VERSION})
63+
KOPS_SERVER_TAG := $(subst +,-,${VERSION})
6364

6465
# Go exports:
6566

@@ -500,7 +501,7 @@ kops-server-build:
500501
docker pull golang:${GOVERSION}
501502
docker run --name=kops-server-build-${UNIQUE} -e STATIC_BUILD=yes -e VERSION=${VERSION} -v ${GOPATH}/src:/go/src -v ${MAKEDIR}:/go/src/k8s.io/kops golang:${GOVERSION} make -f /go/src/k8s.io/kops/Makefile kops-server-docker-compile
502503
docker cp kops-server-build-${UNIQUE}:/go/.build .
503-
docker build -t ${DOCKER_REGISTRY}/kops-server:latest -f images/kops-server/Dockerfile .
504+
docker build -t ${DOCKER_REGISTRY}/kops-server:${KOPS_SERVER_TAG} -f images/kops-server/Dockerfile .
504505

505506
.PHONY: kops-server-push
506507
kops-server-push: kops-server-build

images/kops-server/Dockerfile

+3-1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
FROM alpine:3.5
15+
FROM gcr.io/google_containers/debian-base-amd64:0.1
16+
# TODO
17+
# RUN apt-get update && apt-get install --yes --reinstall lsb-base
1618
COPY /.build/dist/linux/amd64/kops-server /kops-server
1719
ENTRYPOINT "/kops-server"

0 commit comments

Comments
 (0)