feat: e2e latency as target #145
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
in a lot of use cases, we will use request latency as a constraint instread of TTFT and TPOT breakdown especially in agent mode. This feature will introduce a new argument request_latency to cli and sdk. (not for webapp now, will add in future).
an example,
Output:
CLI will automatically switch to request latency mode and print relevant pareto frontier.
Tests are covered in basic sdk and cli workflow.
A manual test is in tests/cli/e2e_validation/test_request_latency.py
tests/cli/e2e_validation/test_request_latency_example.py::TestRequestLatencyExample::test_request_latency_doc_example[trtllm-True] PASSED [ 33%]
tests/cli/e2e_validation/test_request_latency_example.py::TestRequestLatencyExample::test_request_latency_doc_example[sglang-False] PASSED [ 66%]
tests/cli/e2e_validation/test_request_latency_example.py::TestRequestLatencyExample::test_request_latency_doc_example[vllm-False] PASSED [100%]