modified logic

Author: vanshilshah97

lib/llm/src/local_model.rs

@@ -18,6 +18,7 @@ use crate::entrypoint::RouterConfig;
 use crate::mocker::protocols::MockEngineArgs;
 use crate::model_card::{self, ModelDeploymentCard};
 use crate::model_type::{ModelInput, ModelType};
+#[cfg(feature = "media-loading")]
 use crate::preprocessor::media::MediaDecoder;
 use crate::request_template::RequestTemplate;
 
@@ -57,6 +58,7 @@ pub struct LocalModelBuilder {
     namespace: Option<String>,
     custom_backend_metrics_endpoint: Option<String>,
     custom_backend_metrics_polling_interval: Option<f64>,
+    #[cfg(feature = "media-loading")]
     media_decoder: Option<MediaDecoder>,
 }
 
@@ -83,6 +85,7 @@ impl Default for LocalModelBuilder {
             namespace: Default::default(),
             custom_backend_metrics_endpoint: Default::default(),
             custom_backend_metrics_polling_interval: Default::default(),
+            #[cfg(feature = "media-loading")]
             media_decoder: Default::default(),
         }
     }
@@ -191,6 +194,7 @@ impl LocalModelBuilder {
         self
     }
 
+    #[cfg(feature = "media-loading")]
     pub fn media_decoder(&mut self, media_decoder: Option<MediaDecoder>) -> &mut Self {
         self.media_decoder = media_decoder;
         self
@@ -242,8 +246,11 @@ impl LocalModelBuilder {
             card.migration_limit = self.migration_limit;
             card.user_data = self.user_data.take();
             card.runtime_config = self.runtime_config.clone();
-            //card.media_decoder = self.media_decoder.clone();
-            card.media_decoder = Some(MediaDecoder::default());
+            #[cfg(feature = "media-loading")]
+            {
+                //card.media_decoder = self.media_decoder.clone();
+                card.media_decoder = Some(MediaDecoder::default());
+            }
 
             return Ok(LocalModel {
                 card,
@@ -294,7 +301,10 @@ impl LocalModelBuilder {
         card.migration_limit = self.migration_limit;
         card.user_data = self.user_data.take();
         card.runtime_config = self.runtime_config.clone();
-        card.media_decoder = Some(MediaDecoder::default());
+        #[cfg(feature = "media-loading")]
+        {
+            card.media_decoder = Some(MediaDecoder::default());
+        }
 
         Ok(LocalModel {
             card,

lib/llm/src/model_card.rs

@@ -29,6 +29,7 @@ use dynamo_runtime::{slug::Slug, storage::key_value_store::Versioned};
 use serde::{Deserialize, Serialize};
 use tokenizers::Tokenizer as HfTokenizer;
 
+#[cfg(feature = "media-loading")]
 use crate::preprocessor::media::MediaDecoder;
 use crate::protocols::TokenIdType;
 
@@ -223,6 +224,7 @@ pub struct ModelDeploymentCard {
     pub runtime_config: ModelRuntimeConfig,
 
     /// Media decoding configuration
+    #[cfg(feature = "media-loading")]
     #[serde(default)]
     pub media_decoder: Option<MediaDecoder>,
 
@@ -553,6 +555,7 @@ impl ModelDeploymentCard {
             model_input: Default::default(), // set later
             user_data: None,
             runtime_config: ModelRuntimeConfig::default(),
+            #[cfg(feature = "media-loading")]
             media_decoder: None,
             checksum: OnceLock::new(),
         })

lib/llm/src/preprocessor.rs

@@ -27,6 +27,7 @@ use std::{collections::HashMap, pin::Pin, sync::Arc};
 use tracing;
 
 use crate::model_card::{ModelDeploymentCard, ModelInfo};
+#[cfg(feature = "media-loading")]
 use crate::preprocessor::media::{MediaDecoder, MediaLoader};
 use crate::preprocessor::prompt::OAIChatLikeRequest;
 use crate::protocols::common::preprocessor::MultimodalDataMap;
@@ -114,6 +115,7 @@ pub struct OpenAIPreprocessor {
     /// Per-model runtime configuration propagated to response generator (e.g., reasoning/tool parser)
     runtime_config: crate::local_model::runtime_config::ModelRuntimeConfig,
     tool_call_parser: Option<String>,
+    #[cfg(feature = "media-loading")]
     media_loader: Option<MediaLoader>,
 }
 
@@ -153,19 +155,14 @@ impl OpenAIPreprocessor {
             }
         };
 
-        #[cfg(not(feature = "media-loading"))]
-        let media_loader = {
-            let _ = mdc; // silence unused warning when feature disabled
-            None
-        };
-
         Ok(Arc::new(Self {
             formatter,
             tokenizer,
             model_info,
             mdcsum,
             runtime_config,
             tool_call_parser,
+            #[cfg(feature = "media-loading")]
             media_loader,
         }))
     }
@@ -328,10 +325,18 @@ impl OpenAIPreprocessor {
 
                 let map_item = media_map.entry(type_str.clone()).or_default();
 
-                if let Some(loader) = &self.media_loader {
-                    let rdma_descriptor = loader.fetch_and_decode_media_part(content_part).await?;
-                    map_item.push(MultimodalData::Decoded(rdma_descriptor));
-                } else {
+                #[cfg(feature = "media-loading")]
+                {
+                    if let Some(loader) = &self.media_loader {
+                        let rdma_descriptor = loader.fetch_and_decode_media_part(content_part).await?;
+                        map_item.push(MultimodalData::Decoded(rdma_descriptor));
+                    } else {
+                        map_item.push(MultimodalData::Url(url));
+                    }
+                }
+                #[cfg(not(feature = "media-loading"))]
+                {
+                    let _ = content_part; // silence unused
                     map_item.push(MultimodalData::Url(url));
                 }
             }

lib/llm/src/preprocessor/media/mod.rs

@@ -14,55 +14,3 @@ pub use common::{Decoder, EncodedMediaData, MediaDecoder, MediaLoader, RdmaMedia
 pub use image::ImageDecoder;
 #[cfg(feature = "media-loading")]
 pub use video::VideoDecoder;
-
-// Fallback stub APIs when media-loading feature is disabled
-#[cfg(not(feature = "media-loading"))]
-pub trait Decoder {}
-
-#[cfg(not(feature = "media-loading"))]
-#[derive(Clone, Debug, Default, serde::Serialize, serde::Deserialize)]
-pub struct ImageDecoder {
-    pub max_pixels: Option<usize>,
-}
-
-#[cfg(not(feature = "media-loading"))]
-#[derive(Clone, Debug, Default, serde::Serialize, serde::Deserialize)]
-pub struct VideoDecoder {
-    pub fps: Option<f32>,
-    pub max_frames: Option<u32>,
-    pub num_frames: Option<u32>,
-    pub strict: bool,
-    pub max_pixels: Option<usize>,
-}
-
-#[cfg(not(feature = "media-loading"))]
-#[derive(Clone, Debug, Default, serde::Serialize, serde::Deserialize)]
-pub struct MediaDecoder {
-    pub image_decoder: ImageDecoder,
-    pub video_decoder: VideoDecoder,
-}
-
-#[cfg(not(feature = "media-loading"))]
-#[derive(serde::Serialize, serde::Deserialize, Clone, Debug)]
-pub struct RdmaMediaDataDescriptor {}
-
-#[cfg(not(feature = "media-loading"))]
-pub struct MediaLoader;
-
-#[cfg(not(feature = "media-loading"))]
-impl MediaLoader {
-    pub fn new(_media_decoder: MediaDecoder) -> anyhow::Result<Self> {
-        anyhow::bail!(
-            "media-loading feature is disabled; enable 'media-loading' feature to use MediaLoader"
-        )
-    }
-
-    pub async fn fetch_and_decode_media_part(
-        &self,
-        _oai_content_part: &dynamo_async_openai::types::ChatCompletionRequestUserMessageContentPart,
-    ) -> anyhow::Result<RdmaMediaDataDescriptor> {
-        anyhow::bail!(
-            "media-loading feature is disabled; cannot fetch/decode media without feature"
-        )
-    }
-}

lib/llm/src/protocols/common/preprocessor.rs

@@ -6,13 +6,15 @@ use serde::{Deserialize, Serialize};
 
 use super::{OutputOptions, SamplingOptions, StopConditions};
 use crate::kv_router::RouterConfigOverride;
+#[cfg(feature = "media-loading")]
 use crate::preprocessor::media::RdmaMediaDataDescriptor;
 use crate::protocols::TokenIdType;
 
 #[derive(Serialize, Deserialize, Debug, Clone)]
 #[serde(untagged)]
 pub enum MultimodalData {
     Url(url::Url),
+    #[cfg(feature = "media-loading")]
     Decoded(RdmaMediaDataDescriptor),
 }