Use combineSubtraction to cutout overlapping sections
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
changed the title
combineIntersection to cutout overlapping sectionscombineSubtraction to cutout overlapping sections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a
makerjs'scombineSubtractionAPI to combine the overlapping cutouts into a single path. Eg,[[{x:-1,w:2},""]](a 2u stabilizer key) with Cherry MX Spec cutouts goes from:to:
This allows the generated DXF file to be imported back into Kicad to generate PCB cutouts.
I also fixed #10. There was a type confusion when trying to parse the JSON, a keyboard with a single row looks like a JSON file and we tried to iterate each key as if it were a row.