Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version consistency check #10

Open
mfherbst opened this issue Nov 7, 2024 · 2 comments
Open

Version consistency check #10

mfherbst opened this issue Nov 7, 2024 · 2 comments

Comments

@mfherbst
Copy link
Collaborator

mfherbst commented Nov 7, 2024

The python-side aiida-dftk and the julia-side AiidaDFTK.jl will inevitably have some form of version locking, in the sense that their expected IO interfaces depend on each other. We should agree on some convention about this.

E.g. will the semantic versioning in AiidaDFTK.jl reflect breaking changes where aiida-dftk needs to change ? If yes, then some for of checking of the version should probably occurr in aiida-dftk ?

@Technici4n
Copy link
Collaborator

I added

[compat]
AiidaDFTK = "0.1"

in the test environment under the assumption that we'd bump AiidaDFTK to 0.2 when breaking changes happen.

There should be some check at runtime too, I agree. We can either insert it in the julia -e argument, or add some "format version" to the json file. ({ "version": 1, ... })

@mfherbst
Copy link
Collaborator Author

I think I would indeed add a check somewhere using e.g.

using AiidaDFTK
using Pkg
@assert v"0.1.9" <= pkgver(AiidaDFTK) < v"0.2" 

or simila.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants