Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement features now available in DFTK #7

Open
3 tasks
mfherbst opened this issue Jan 18, 2024 · 3 comments
Open
3 tasks

Implement features now available in DFTK #7

mfherbst opened this issue Jan 18, 2024 · 3 comments

Comments

@mfherbst
Copy link
Collaborator

mfherbst commented Jan 18, 2024

Things already available in AiidaDFTK, but not in here:

  • The file "self_consistent_field.json" now contains all SCF information without ρ and ψ
  • The JLD2 file referenced by "scf/checkpointfile" contains all data of the JSON, plus additionally ρ, but not ψ. It is used automatically to restart a calculation if it is present. Can be read using h5py.
  • If "scf/save_ψ" is true, then this JLD2 file contains both ρ and ψ. It can be read using h5py from python.

Things which are available in DFTK and which we could easily make available here:

@mfherbst
Copy link
Collaborator Author

Tagging @azadoks

@WuyihanVictor
Copy link
Collaborator

@mfherbst
Copy link
Collaborator Author

mfherbst commented Mar 14, 2024

I have a draft implementaion of "maxtime" and "compute_bands" in my fork of AiidaDFTK

Great, can you open a PR? Then we can discuss your open points there.

we need to decide whether to wirte a new DftkBandsWorkchain

No idea. I mean in principle once the SCF result has been written to disk, the band computation should be fast, so one could call AiidaDFTK a second time to kick that calculation off. @azadoks What you you think is better ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants