From 9fe8fd2e0b88e746ee2156eccb71b7adbab6b2c5 Mon Sep 17 00:00:00 2001
From: Sebastiaan Huber <mail@sphuber.net>
Date: Mon, 1 Jul 2024 13:33:46 +0200
Subject: [PATCH] Fixtures: Make `pgtest` truly an optional dependency (#6502)

The pytest fixtures were improved to allow running with a
`core.sqlite_dos` storage for the test profile, making PostgreSQL
completely optional. However, the current fixture still imports the
`pgtest` package at module level making it a requirement, despite it
only being relevant when running the tests with a `core.psql_dos`
storage plugin.

Here the import is moved inside the `PostgresCluster._create` method
which is only called when the test suite actually uses a PSQL based
storage plugin.
---
 src/aiida/tools/pytest_fixtures/storage.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/aiida/tools/pytest_fixtures/storage.py b/src/aiida/tools/pytest_fixtures/storage.py
index 2f13cf25a1..4565e621b4 100644
--- a/src/aiida/tools/pytest_fixtures/storage.py
+++ b/src/aiida/tools/pytest_fixtures/storage.py
@@ -7,7 +7,6 @@
 from uuid import uuid4
 
 import pytest
-from pgtest.pgtest import PGTest
 
 if t.TYPE_CHECKING:
     from pgtest.pgtest import PGTest
@@ -19,6 +18,8 @@ def __init__(self):
         self.cluster = None
 
     def _create(self):
+        from pgtest.pgtest import PGTest
+
         try:
             self.cluster = PGTest()
         except OSError as e:
@@ -59,7 +60,6 @@ def create_database(
         return postgres_config
 
 
-# TODO: Update docstring accordingly
 @pytest.fixture(scope='session')
 def postgres_cluster():
     """Create a temporary and isolated PostgreSQL cluster using ``pgtest`` and cleanup after the yield.