CLI: Remove the RabbitMQ options from verdi profile setup

For the vast majority of use cases, users will have a default setup for
RabbitMQ and so the default configuration will be adequate and so they
will not need the options in the command. On the flipside, showing the
options by default can makes the command harder to use as users will
take pause to think what value to pass.

Since there is the `verdi profile configure-rabbitmq` command now that
allows to configure or reconfigure the RabbitMQ connection parameters
for an existing profile, it is fine to remove these options from the
profile setup. Advanced users that need to customize the connection
parameters can resort to that separate command.

Author: sphuber

src/aiida/cmdline/commands/cmd_profile.py

@@ -39,6 +39,7 @@ def command_create_profile(
     :param set_as_default: Whether to set the created profile as the new default.
     :param kwargs: Arguments to initialise instance of the selected storage implementation.
     """
+    from aiida.brokers.rabbitmq.defaults import detect_rabbitmq_config
     from aiida.plugins.entry_point import get_entry_point_from_class
 
     if not storage_cls.read_only and kwargs.get('email', None) is None:
@@ -52,22 +53,15 @@ def command_create_profile(
     _, storage_entry_point = get_entry_point_from_class(storage_cls.__module__, storage_cls.__name__)
     assert storage_entry_point is not None
 
-    if kwargs.pop('use_rabbitmq'):
-        broker_backend = 'core.rabbitmq'
-        broker_config = {
-            key: kwargs.get(key)
-            for key in (
-                'broker_protocol',
-                'broker_username',
-                'broker_password',
-                'broker_host',
-                'broker_port',
-                'broker_virtual_host',
-            )
-        }
+    broker_config = detect_rabbitmq_config()
+    broker_backend = 'core.rabbitmq' if kwargs.get('use_rabbitmq', False) else None
+
+    if broker_config is None:
+        echo.echo_warning('RabbitMQ server not found: configuring the profile without a broker.')
     else:
-        broker_backend = None
-        broker_config = None
+        echo.echo_success('RabbitMQ server detected: configuring the profile with a broker.')
+
+    echo.echo_report('RabbitMQ connection parameters can be reconfigured with `verdi profile configure-rabbitmq`.')
 
     try:
         profile = create_profile(
@@ -104,24 +98,6 @@ def command_create_profile(
         setup.SETUP_USER_LAST_NAME(),
         setup.SETUP_USER_INSTITUTION(),
         setup.SETUP_USE_RABBITMQ(),
-        setup.SETUP_BROKER_PROTOCOL(
-            prompt_fn=lambda ctx: ctx.params['use_rabbitmq'], required_fn=lambda ctx: ctx.params['use_rabbitmq']
-        ),
-        setup.SETUP_BROKER_USERNAME(
-            prompt_fn=lambda ctx: ctx.params['use_rabbitmq'], required_fn=lambda ctx: ctx.params['use_rabbitmq']
-        ),
-        setup.SETUP_BROKER_PASSWORD(
-            prompt_fn=lambda ctx: ctx.params['use_rabbitmq'], required_fn=lambda ctx: ctx.params['use_rabbitmq']
-        ),
-        setup.SETUP_BROKER_HOST(
-            prompt_fn=lambda ctx: ctx.params['use_rabbitmq'], required_fn=lambda ctx: ctx.params['use_rabbitmq']
-        ),
-        setup.SETUP_BROKER_PORT(
-            prompt_fn=lambda ctx: ctx.params['use_rabbitmq'], required_fn=lambda ctx: ctx.params['use_rabbitmq']
-        ),
-        setup.SETUP_BROKER_VIRTUAL_HOST(
-            prompt_fn=lambda ctx: ctx.params['use_rabbitmq'], required_fn=lambda ctx: ctx.params['use_rabbitmq']
-        ),
     ],
 )
 def profile_setup():