Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error when user tries to submit workflow without rabbitmq broker #6374

Closed
danielhollas opened this issue Apr 27, 2024 · 2 comments · Fixed by #6465
Closed

Better error when user tries to submit workflow without rabbitmq broker #6374

danielhollas opened this issue Apr 27, 2024 · 2 comments · Fixed by #6465
Assignees
Labels
good first issue Issues that should be relatively easy to fix also for beginning contributors type/enhancement

Comments

@danielhollas
Copy link
Collaborator

When a user creates a profile with verdi presto without rabbitmq broker, and tries to submit a Workflow to a daemon via submit they will be greeted with this assert

    113     runner = manager.get_manager().get_runner()
    114     assert runner.persister is not None, 'runner does not have a persister'
--> 115     assert runner.controller is not None, 'runner does not have a controller'
    116 
    117     process_inited = instantiate_process(runner, process, **inputs)

AssertionError: runner does not have a controller

Since this will likely become a common problem for newcommers, we should provide a clear error message.

Should be done as a follow-up (or part of #6351)

@danielhollas danielhollas added good first issue Issues that should be relatively easy to fix also for beginning contributors type/enhancement labels Apr 27, 2024
@danielhollas danielhollas changed the title Better error Better error when user tries to submit workflow without rabbitmq broker Apr 27, 2024
@sphuber sphuber self-assigned this Apr 27, 2024
@mbercx
Copy link
Member

mbercx commented Apr 28, 2024

Good point @danielhollas! Also note that even in the basic tutorial we have a section where we submit to the daemon:

https://aiida.readthedocs.io/projects/aiida-core/en/stable/intro/tutorial.html#submitting-to-the-daemon

Maybe we should also add a warning here that this will only work in case they have a RabbitMQ broker configured.

Ideally they'd also be able to reconfigure the same profile to use a RabbitMQ broker, but I suppose that'd be beyond the scope of this issue. 😇

@sphuber
Copy link
Contributor

sphuber commented Jun 6, 2024

Ideally they'd also be able to reconfigure the same profile to use a RabbitMQ broker, but I suppose that'd be beyond the scope of this issue. 😇

This particular piece of scope creep is addressed here #6454

I will submit a separate PR to address the original issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that should be relatively easy to fix also for beginning contributors type/enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants