Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong num_tests in verdi computer test when fails to open a connection #6530

Closed
khsrali opened this issue Jul 16, 2024 · 0 comments · Fixed by #6536
Closed

Wrong num_tests in verdi computer test when fails to open a connection #6530

khsrali opened this issue Jul 16, 2024 · 0 comments · Fixed by #6536
Labels

Comments

@khsrali
Copy link
Contributor

khsrali commented Jul 16, 2024

If verdi computer test fails in connection stage, it shows something like:

Report: Testing computer<sshFabric_baby> for user<[email protected]>...
* Opening connection... [FAILED]: Error while trying to connect to the computer
  Use the `--print-traceback` option to see the full traceback.
Warning: 1 out of 0 tests failed

reports the total run tests as zero. The reason is here the context manager fails on __enter__ before adding up 1 to num_tests

try:
    echo.echo('* Opening connection... ', nl=False)

    with transport:
        num_tests += 1

I think this is because, it was assumed that connection can never fail once core.ssh is set up. However this may not be the case always #6154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant