Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verdi devel check-undesired-imports fails when tui extras is installed #6691

Open
danielhollas opened this issue Jan 9, 2025 · 0 comments · May be fixed by #6693
Open

verdi devel check-undesired-imports fails when tui extras is installed #6691

danielhollas opened this issue Jan 9, 2025 · 0 comments · May be fixed by #6693
Labels

Comments

@danielhollas
Copy link
Collaborator

verdi devel check-undesired-imports makes sure that we don't have heavy imports during verdi startup to keep the CLI snappy (especially for tab completion).

One of the expensive modules that it checks is asyncio. Unfortunately, when you install the tui extra, the trogon package that powers the tui functionality seems to use asyncio, and this makes the test fail.
(indeed, one of the TUIs current downsides is that it makes all CLI interactions slower, even if you don't use the TUI subcommand).

We should make the test more clever and don't check for asyncio import when tui extras is installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant