Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Rebirth Transfer Protection #315

Open
1 task
LordChanning opened this issue Aug 29, 2020 · 3 comments · May be fixed by #412
Open
1 task

[Bug] Rebirth Transfer Protection #315

LordChanning opened this issue Aug 29, 2020 · 3 comments · May be fixed by #412

Comments

@LordChanning
Copy link

Complete these first

  • [x ] I confirm that I am the owner of the bot running Adventure.
  • [x ] I confirm that I have not modified the source code of Adventure.
  • I'm an Adventure user but not the bot owner.
  • [x ] I confirm that I have checked the issue tracker and a this bug hasn't been reported already.

Expected Behavior

Rebirth protection message that makes you get up to x gold remains consistent

Current Behavior

3.4.3
A user can bypass this feature by depositing some gold back in after withdrawing the gold.

Possible Solution

N/A

Steps to Reproduce

  1. Earn some gold & get up to a high enough level where you can rebirth
  2. Use the !atransfer withdraw command to extract all gold
  3. Try & rebirth -> rebirth message pops up "You tried to get rid of all your gold coins -- tsk tsk, once you get back up to 7,852 gold coins try again."
  4. Use the !atransfer deposit command to put 10 gold back in
  5. Try & rebirth -> Rebirth is successful
    Screenshot (4155)

Context (Environment)

I am trying to make sure all users have to pay the rebirth costs and are unable to bypass it using any methods

Detailed Description

Users still have to pay rebirth costs even after withdrawing and depositing

Possible Implementation

N/A

@LordChanning
Copy link
Author

Forgot to mention this above ^

The user did not earn any gold that could've put them above 7,852 + rebirth tax is at 75%

@tmoze315
Copy link

I am trying to make sure all users have to pay the rebirth costs and are unable to bypass it using any methods

I wanted to offer my thoughts on this. Personally I think it is a lot of work trying to catch all the ways in which a user can avoid paying the rebirth cost. And the target is always going to be moving when new features are added, as it could introduce new ways to avoid the cost.

Rather than making it impossible for users to avoid the cost under some situations, why don't we make it so arduous that people simply don't do it. If they really have an issue with the rebirth cost, they can take it up with the admins of the server and change the Base Rebirth Cost setting.

What do I mean by arduous? How about preventing somebody from transferring money or receiving money for 24 hours after they rebirth (and no trading items)? Somebody is not going to want to hold money for a day, and it gets confusing about how much to send back if any is lost through battle. Technically it's possible to avoid paying the cost this way, but it would put people off doing it because it isn't worth it.

@Dark-lame
Copy link

Having a similar issue, even without a separated currency system
image
This is happening on version 3.5.3, so still a newer version than the previous instances but its a prevalent issue.

I agree with tmoze that its easier for us as mods and devs to make it much harder to achieve this, but many variables need to be considered so we dont misfire anyone. For reference, !pay is a disabled command in the server so a timeout on paying after a rebirth is infeasible.

Instead, it might be possible to save the cost for rebirth when the user reaches their max level. (the larger number) so if and when they come to do !rebirth the second time, the first rebirth cost is saved and then shown, even if they do transactions in between the time of reaching max level and physically rebirthing. Currently, if the user alters their balance it resets the initial save for the rebirth cost.

Even if the user increases their balance, the rebirth cost should stay flat. the proposed solution should alleviate the issue.

Drapersniper added a commit to Drapersniper/gobcog that referenced this issue Oct 2, 2022
Drapersniper added a commit to Drapersniper/gobcog that referenced this issue Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants