-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regexp functions support #13
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 96.13% 96.30% +0.17%
==========================================
Files 17 17
Lines 362 379 +17
==========================================
+ Hits 348 365 +17
Misses 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
As other solution, string mode may be replaced directly with callable F.text.regexp(r"(\w+-\d+)", mode=re.findall).as_("issues"), |
It can be completed without making it breaking. For example you can set mode by default to
|
@JrooTJunior, okay, I'll take it. What do you prefer enum params or callable? |
I'd like to use enum or literals instead of passing methods in due to instead of re methods can be passed any function |
Modified the 'in_' and 'not_in' methods in 'magic_filter/magic.py' to accept both 'Container' and 'MagicT' types as iterable. This change provides more flexibility in specifying iterables in these methods and broadens their potential usage.
Closes #12