-
Notifications
You must be signed in to change notification settings - Fork 26.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lines-around-directive
rule should replaced with padding-line-between-statements
#2689
Comments
Hi there, I want to contribute to this project and take on this issue as my first task. Could you please assign it to me? I am excited to work towards resolving it and will keep the team updated on my progress. Thanks! |
@HemanthPaila theres no need to request assignment; most open source projects don’t operate that way. Just make a PR and link it to the issue. |
Thanks @ljharb . I am on it. |
I made a PR on this issue. could you please review and merge it? |
Hello sir i made another PR could you please review it once? |
@HemanthPaila please don't make duplicate PRs - now both #2756 and #2757 must remain open and be kept in sync. I've reviewed it, and in the future you don't need to ask for review, you can just wait more than a few minutes :-) |
Sir could you please clarify my doubt: |
is the issue resolved? |
No, the linked PR, #2757, has unresolved comments. |
see eslint/eslint#16629 (comment) from the eslint maintainer
The text was updated successfully, but these errors were encountered: