-
Notifications
You must be signed in to change notification settings - Fork 26.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of new eslint flat config #2804
Comments
sadly yes, that's true. |
I can do the PR if you want, is there a release branch? |
Actually we may need to wait until all of our peer deps support flat config. If that’s already working, then a PR to the default branch is fine. |
how should i contribute , where to start |
@ljharb, I don't know the exact process on this project, but here's a PR from a fork: https://github.com/airbnb/javascript/pull/2818/files |
A PR for adding You can already use flat config, even when using plugins and configs that don't yet support it, by using I don't think we need to wait for full flat config support to allow importing dev dependencies from flat config files. |
After upgrade to eslint 9.0.0. now i see error |
This comment was marked as off-topic.
This comment was marked as off-topic.
is this library not suported ? |
Every config needs to be updated to support new v9 eslint API, which has breaking changes. Since v9 has been released yesterday, we probably need to wait for configs’ compatibility (see eslint/typescript, which has a dedicated issue with thread about it and tracking). |
Correct; just like with every eslint major, all the plugins this config depends on have to support it before we can. |
airbnb-base not fully supported yet: airbnb/javascript#2804
For reference, tracking issues for plugins which need to be resolved first: import-js/eslint-plugin-import#2556 jsx-eslint/eslint-plugin-react#3699 jsx-eslint/eslint-plugin-jsx-a11y#978 @ljharb have I missed anything? |
eslint-find-rules, as well. |
Hello! Have we got any expectation when approximately airbnb flatconfig will be ready? Some days, weeks, or months? |
@iserdmi nope. in the past it's taken multiple months to support a new eslint major, but this one is more disruptive and difficult to migrate to, so it might take longer. |
airbnb-base not fully supported yet: airbnb/javascript#2804
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as resolved.
This comment was marked as resolved.
@ljharb I think this issue is only about adding |
@efoken you shouldn't be using flat config with this plugin at all until we actually support it. |
@ljharb as long as people use ESLint 8 with flat config and use the Airbnb config with compat there isn't any problem, everything works perfect 😉 |
Sorry if this is all very obvious, and I'm just not understanding it. It seems like there are several possible (theoretical) scenarios:
I believe the ultimate goal is № 6. Based on the @efoken's comment above, it seems like № 3 also works. Is there a benefit to switching to flat config on ESLint 8, other than a slightly smoother upgrade to ESLint 9 down the road? And is it true that neither № 4 or № 5 work? |
1 is already possible, obviously. 2 and 5 might work, but neither eslint nor myself will likely be able to effectively support you, so you're kind of on your own with those. This issue tracks number 3 (and unblocks 6, once 4 is achievable). Number 4 (and thus 6) is tracked in #2961. |
Hi,
eslint.config.js
should be added injavascript/packages/eslint-config-airbnb-base/rules/imports.js
Line 94 in cda44da
Thanks!
The text was updated successfully, but these errors were encountered: