Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutual inforamtion loss normaliser 1d & 2d redundant? #32

Open
qiuhuaqi opened this issue Jun 15, 2020 · 0 comments
Open

Mutual inforamtion loss normaliser 1d & 2d redundant? #32

qiuhuaqi opened this issue Jun 15, 2020 · 0 comments

Comments

@qiuhuaqi
Copy link

This step computing the joint distribution in MI pairwise loss:

p_joint = th.mm(p_f, p_m.transpose(0, 1)).div(self._normalizer_2d)

The marginal distributions are already normalised by self._normalizer_1d in:

def _compute_marginal_entropy(self, values, bins):

I might be mistaken. But doesn't the joint distribution no longer need normalisation (self._normalizer_2d) as its the outer product of the normalised marginal distributions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant