Skip to content

Commit 887a780

Browse files
authoredJul 26, 2022
Fix cspell workflow. (aws#2010)
1 parent 6709bb6 commit 887a780

30 files changed

+63
-48
lines changed
 

‎CONTRIBUTING.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ If your branch has more than one commit when it's approved, you will also be ask
8585
* Use RAII, Aws::New and Aws::Delete should only appear in constructors and destructors.
8686
* Be sure to follow the rule of 5.
8787
* Use the C++ 11 standard where possible.
88-
* Use UpperCamelCase for custom type names and function names. Use m_* for member variables. Don't use statics. If you must, use UpperCammelCase for static variables
89-
* Always be const correct, and be mindful of when you need to support r-values. We don't trust compilers to optimize this uniformly accross builds so please be explicit.
88+
* Use UpperCamelCase for custom type names and function names. Use m_* for member variables. Don't use statics. If you must, use UpperCamelCase for static variables
89+
* Always be const correct, and be mindful of when you need to support r-values. We don't trust compilers to optimize this uniformly across builds so please be explicit.
9090
* Namespace names should be UpperCammelCase. Never put a using namespace statement in a header file unless it is scoped by a class. It is fine to use a using namespace statement in a cpp file.
9191
* Use enum class, not enum
9292
* Prefer `#pragma once` for include guards.

‎Docs/CODING_STANDARDS.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* Be sure to follow the rule of 5.
99
* Use the C++ 11 standard where possible.
1010
* Use UpperCamelCase for custom type names and function names. Use m_* for member variables. Don't use statics. If you must, use UpperCamelCase for static variables
11-
* Always be const correct, and be mindful of when you need to support r-values. We don't trust compilers to optimize this uniformly accross builds so please be explicit.
11+
* Always be const correct, and be mindful of when you need to support r-values. We don't trust compilers to optimize this uniformly across builds so please be explicit.
1212
* Namespace names should be UpperCamelCase. Never put a using namespace statement in a header file unless it is scoped by a class. It is fine to use a using namespace statement in a cpp file.
1313
* Use enum class, not enum
1414
* Prefer #pragma once for include guards.

‎Docs/Credentials_Providers.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ You can use the AWSCredentialProvider interface to provide login credentials to
55
The default credential provider chain does the following:
66
1. Checks your environment variables for AWS Credentials
77
2. Checks your $HOME/.aws/credentials file for a profile and credentials
8-
3. Contacts and logs in to a trusted identity provider (Cognito, Login with Amazon, Facebook, Google). The sdk looks for the login information to these providers either on the enviroment variables: AWS_ROLE_ARN, AWS_WEB_IDENTITY_TOKEN_FILE, AWS_ROLE_SESSION_NAME. Or on a profile in your $HOME/.aws/credentials.
8+
3. Contacts and logs in to a trusted identity provider (Cognito, Login with Amazon, Facebook, Google). The sdk looks for the login information to these providers either on the environment variables: AWS_ROLE_ARN, AWS_WEB_IDENTITY_TOKEN_FILE, AWS_ROLE_SESSION_NAME. Or on a profile in your $HOME/.aws/credentials.
99
4. Checks for an external method set as part of a profile on $HOME/.aws/config to generate or look up credentials that isn't directly supported by AWS.
1010
5. Contacts the ECS TaskRoleCredentialsProvider service to request credentials if Environment variable AWS_CONTAINER_CREDENTIALS_RELATIVE_URI has been set.
1111
6. Contacts the EC2MetadataInstanceProfileCredentialsProvider service to request credentials if AWS_EC2_METADATA_DISABLED is NOT set to ON.

‎README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ To build for Docker, ensure your container meets the [minimum requirements](#min
101101

102102

103103
### Building and running an app on EC2
104-
Checkout this walkthrough on how to set up an enviroment and build the [AWS SDK for C++ on an EC2 instance](https://github.com/aws/aws-sdk-cpp/wiki/Building-the-SDK-from-source-on-EC2).
104+
Checkout this walk through on how to set up an environment and build the [AWS SDK for C++ on an EC2 instance](https://github.com/aws/aws-sdk-cpp/wiki/Building-the-SDK-from-source-on-EC2).
105105

106106
# Issues and Contributions
107107
We welcome all kinds of contributions, check [this guideline](./CONTRIBUTING.md) to learn how you can contribute or report issues.

‎aws-cpp-sdk-core/include/aws/core/client/AWSClient.h

+4-4
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ namespace Aws
8080
typedef Utils::Outcome<AmazonWebServiceResult<Utils::Stream::ResponseStream>, AWSError<CoreErrors>> StreamOutcome;
8181

8282
/**
83-
* Abstract AWS Client. Contains most of the functionality necessary to build an http request, get it signed, and send it accross the wire.
83+
* Abstract AWS Client. Contains most of the functionality necessary to build an http request, get it signed, and send it across the wire.
8484
*/
8585
class AWS_CORE_API AWSClient
8686
{
@@ -211,7 +211,7 @@ namespace Aws
211211
const char* signerServiceNameOverride = nullptr) const;
212212

213213
/**
214-
* Build an Http Request from the AmazonWebServiceRequest object. Signs the request, sends it accross the wire
214+
* Build an Http Request from the AmazonWebServiceRequest object. Signs the request, sends it across the wire
215215
* then reports the http response.
216216
*/
217217
HttpResponseOutcome AttemptOneRequest(const std::shared_ptr<Http::HttpRequest>& httpRequest,
@@ -221,7 +221,7 @@ namespace Aws
221221
const char* signerServiceNameOverride = nullptr) const;
222222

223223
/**
224-
* Signs an Http Request, sends it accross the wire
224+
* Signs an Http Request, sends it across the wire
225225
* then reports the http response. This method is for payloadless requests e.g. GET, DELETE, HEAD
226226
*
227227
* requestName is used for metrics and defaults to empty string, to avoid empty names in metrics provide a valid
@@ -302,7 +302,7 @@ namespace Aws
302302

303303
/**
304304
* Adds "X-Amzn-Trace-Id" header with the value of _X_AMZN_TRACE_ID if both
305-
* enviroment variables AWS_LAMBDA_FUNCTION_NAME and _X_AMZN_TRACE_ID are set.
305+
* environment variables AWS_LAMBDA_FUNCTION_NAME and _X_AMZN_TRACE_ID are set.
306306
* Does not add/modify header "X-Amzn-Trace-Id" if it is already set.
307307
*/
308308
static void AppendRecursionDetectionHeader(std::shared_ptr<Aws::Http::HttpRequest> ioRequest);

‎aws-cpp-sdk-core/include/aws/core/client/ClientConfiguration.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ namespace Aws
9393
*/
9494
long httpRequestTimeoutMs;
9595
/**
96-
* Socket read timeouts for HTTP clients on Windows. Default 3000 ms. This should be more than adequate for most services. However, if you are transfering large amounts of data
96+
* Socket read timeouts for HTTP clients on Windows. Default 3000 ms. This should be more than adequate for most services. However, if you are transferring large amounts of data
9797
* or are worried about higher latencies, you should set to something that makes more sense for your use case.
9898
* For Curl, it's the low speed time, which contains the time in number milliseconds that transfer speed should be below "lowSpeedLimit" for the library to consider it too slow and abort.
9999
* Note that for Curl this config is converted to seconds by rounding down to the nearest whole second except when the value is greater than 0 and less than 1000. In this case it is set to one second. When it's 0, low speed limit check will be disabled.

‎aws-cpp-sdk-core/include/aws/core/client/RetryStrategy.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,12 @@ namespace Aws
5656
virtual long GetMaxAttempts() const { return 0; }
5757

5858
/**
59-
* Retrives send tokens from the bucket. Throws an exception if not available.
59+
* Retrieves send tokens from the bucket. Throws an exception if not available.
6060
*/
6161
virtual void GetSendToken() {}
6262

6363
/**
64-
* Retrives send tokens from the bucket. Returns true is send token is retrieved.
64+
* Retrieves send tokens from the bucket. Returns true is send token is retrieved.
6565
*/
6666
virtual bool HasSendToken()
6767
{

‎aws-cpp-sdk-core/include/aws/core/external/CommonCryptorSPI.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,7 @@ CCCryptorStatus CCCryptorAddParameter(
461461
/*
462462
Gets value of output cryptor parameter. According to the cryptor
463463
type state, the request can be either accepted or refused with
464-
kCCUnimplemented (when given parameteris not supported for this
464+
kCCUnimplemented (when given parameter is not supported for this
465465
type of cryptor) or kCCBufferTooSmall (in this case, *dataSize
466466
argument is set to the requested size of data).
467467
*/

‎aws-cpp-sdk-core/include/aws/core/http/HttpRequest.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ namespace Aws
126126
*/
127127
virtual bool HasHeader(const char* name) const = 0;
128128
/**
129-
* Get size in bytes of the request when as it will be going accross the wire.
129+
* Get size in bytes of the request when as it will be going across the wire.
130130
*/
131131
virtual int64_t GetSize() const = 0;
132132
/**

‎aws-cpp-sdk-core/include/aws/core/http/curl/CurlHandleContainer.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class CurlHandleContainer
4343
void ReleaseCurlHandle(CURL* handle);
4444

4545
/**
46-
* When the handle has bad DNS entries, problematic live connections, we need to destory the handle from pool.
46+
* When the handle has bad DNS entries, problematic live connections, we need to destroy the handle from pool.
4747
*/
4848
void DestroyCurlHandle(CURL* handle);
4949

‎aws-cpp-sdk-core/include/aws/core/http/standard/StandardHttpRequest.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ namespace Aws
6363
*/
6464
virtual bool HasHeader(const char*) const override;
6565
/**
66-
* Get size in bytes of the request when as it will be going accross the wire.
66+
* Get size in bytes of the request when as it will be going across the wire.
6767
*/
6868
virtual int64_t GetSize() const override;
6969
/**

‎aws-cpp-sdk-core/include/aws/core/http/windows/WinConnectionPoolMgr.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ namespace Aws
5151
void ReleaseConnectionForHost(const Aws::String& host, unsigned port, void* connection);
5252

5353
/**
54-
* Gets the tag for use for the logging system accross the various implementations of this class.
54+
* Gets the tag for use for the logging system across the various implementations of this class.
5555
*/
5656
virtual const char* GetLogTag() const { return "ConnectionPoolMgr"; }
5757
/**

‎aws-cpp-sdk-core/include/aws/core/http/windows/WinHttpConnectionPoolMgr.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ namespace Aws
2222
{
2323
public:
2424
/**
25-
* Initializes the connection pool with the passedin iOpen handle from earlier winHttp init calls.
25+
* Initializes the connection pool with the passed in iOpen handle from earlier winHttp init calls.
2626
* configures connect calls with the timeouts. MaxConnectionsPerHost sets the queue sizes for each endpoint.
2727
*/
2828
WinHttpConnectionPoolMgr(void* iOpenHandle, unsigned maxConnectionsPerHost, long requestTimeout, long connectTimeout);

‎aws-cpp-sdk-core/include/aws/core/http/windows/WinINetConnectionPoolMgr.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ namespace Aws
2121
{
2222
public:
2323
/**
24-
* Initializes the connection pool with the passedin iOpen handle from earlier wininet init calls.
24+
* Initializes the connection pool with the passed in iOpen handle from earlier wininet init calls.
2525
* configures connect calls with the timeouts. MaxConnectionsPerHost sets the queue sizes for each endpoint.
2626
*/
2727
WinINetConnectionPoolMgr(void* iOpenHandle, unsigned maxConnectionsPerHost, long requestTimeout, long connectTimeout);

‎aws-cpp-sdk-core/include/aws/core/http/windows/WinSyncHttpClient.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ namespace Aws
6060
*/
6161
void SetConnectionPoolManager(WinConnectionPoolMgr* connectionMgr);
6262
/**
63-
* Gets the connection pool manager the client is ussing.
63+
* Gets the connection pool manager the client is using.
6464
*/
6565
WinConnectionPoolMgr* GetConnectionPoolManager() const { return m_connectionPoolMgr; }
6666
/**

‎aws-cpp-sdk-core/include/aws/core/monitoring/MonitoringInterface.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ namespace Aws
2626
/**
2727
* @brief This function lets you do preparation work when a http attempt(request) starts. It returns a pointer to an implementation defined context which will be
2828
* passed down with the other facilities that completes the request's lifetime. This context can be used to track the lifetime of the request and record metrics
29-
* specific to this particular request. You are responsible for deleteing the context during your OnFinish call.
29+
* specific to this particular request. You are responsible for deleting the context during your OnFinish call.
3030
* @param serviceName, the service client who initiates this http attempt. like "s3", "ec2", etc.
3131
* @param requestName, the operation or API name of this http attempt, like "GetObject" in s3.
3232
* @param request, the actual Http Request.

‎aws-cpp-sdk-core/include/aws/core/net/SimpleUDP.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ namespace Aws
131131
/**
132132
* @brief Receive data from network.
133133
* @param address, if not null and underlying implementation supply the incoming data's source address, this will be filled with source address info.
134-
* @param addressLength, the size of source adddress, should not be null.
134+
* @param addressLength, the size of source address, should not be null.
135135
* @param buffer, the memory address where you want to store received data.
136136
* @param bufferLen, the size of data buffer.
137137
* @return -1 on failure, check errno for detailed error information, on success, returns the actual bytes of data received.

‎aws-cpp-sdk-core/include/aws/core/utils/Document.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ namespace Aws
3030
* A Document type represents open content that is serialized using the same format as its surroundings and requires no additional encoding or escaping.
3131
* Document types provide a JSON "view" of data regardless of the underlying protocol. This normalized JSON interface makes document types protocol-agnostic.
3232
* Clients can use the data stored in a document without prior knowledge of the protocol by interacting with the normalized JSON view of the data.
33-
* Document types are only initially supported in JSON protocal, so it's identical to Aws::Utils::Json::JsonValue and Aws::Utils::Json::JsonView at this moment.
33+
* Document types are only initially supported in JSON protocol, so it's identical to Aws::Utils::Json::JsonValue and Aws::Utils::Json::JsonView at this moment.
3434
*/
3535
class AWS_CORE_API Document
3636
{

‎aws-cpp-sdk-core/include/aws/core/utils/FileSystemUtils.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ namespace Aws
4545
*/
4646
TempFile(const char* prefix, std::ios_base::openmode openFlags);
4747
/**
48-
* Creates a temporary file with a randome string for the name.
48+
* Creates a temporary file with a random string for the name.
4949
*/
5050
TempFile(std::ios_base::openmode openFlags);
5151

‎aws-cpp-sdk-core/include/aws/core/utils/StringUtils.h

+4-4
Original file line numberDiff line numberDiff line change
@@ -82,30 +82,30 @@ namespace Aws
8282
/**
8383
* @brief Splits a string on a delimiter (empty items are excluded).
8484
* @param toSplit, the original string to split
85-
* @param splitOn, the delemiter you want to use.
85+
* @param splitOn, the delimiter you want to use.
8686
*/
8787
static Aws::Vector<Aws::String> Split(const Aws::String& toSplit, char splitOn);
8888

8989
/**
9090
* @brief Splits a string on a delimiter.
9191
* @param toSplit, the original string to split
92-
* @param splitOn, the delemiter you want to use.
92+
* @param splitOn, the delimiter you want to use.
9393
* @param option, if INCLUDE_EMPTY_ENTRIES, includes empty entries in the result, otherwise removes empty entries.
9494
*/
9595
static Aws::Vector<Aws::String> Split(const Aws::String& toSplit, char splitOn, SplitOptions option);
9696

9797
/**
9898
* @brief Splits a string on a delimiter (empty items are excluded).
9999
* @param toSplit, the original string to split
100-
* @param splitOn, the delemiter you want to use.
100+
* @param splitOn, the delimiter you want to use.
101101
* @param numOfTargetParts, how many target parts you want to get, if it is 0, as many as possible.
102102
*/
103103
static Aws::Vector<Aws::String> Split(const Aws::String& toSplit, char splitOn, size_t numOfTargetParts);
104104

105105
/**
106106
* @brief Splits a string on a delimiter.
107107
* @param toSplit, the original string to split
108-
* @param splitOn, the delemiter you want to use.
108+
* @param splitOn, the delimiter you want to use.
109109
* @param numOfTargetParts, how many target parts you want to get, if it is 0, as many as possible.
110110
* @param option, if INCLUDE_EMPTY_ENTRIES, includes empty entries in the result, otherwise removes empty entries.
111111
*/

‎aws-cpp-sdk-core/include/aws/core/utils/crypto/openssl/CryptoImpl.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ namespace Aws
3939
* OpenSSL implementation for SecureRandomBytes.
4040
* Incidentally, this implementation is thread safe, though it is not
4141
* on other platforms. You should treat an instance of SecureRandomBytes
42-
* as needed to be memory fenced if you will be using accross multiple threads
42+
* as needed to be memory fenced if you will be using across multiple threads
4343
*/
4444
class SecureRandomBytes_OpenSSLImpl : public SecureRandomBytes
4545
{

‎aws-cpp-sdk-core/include/aws/core/utils/threading/Executor.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ namespace Aws
7171

7272
enum class OverflowPolicy
7373
{
74-
QUEUE_TASKS_EVENLY_ACCROSS_THREADS,
74+
QUEUE_TASKS_EVENLY_ACROSS_THREADS,
7575
REJECT_IMMEDIATELY
7676
};
7777

@@ -81,7 +81,7 @@ namespace Aws
8181
class AWS_CORE_API PooledThreadExecutor : public Executor
8282
{
8383
public:
84-
PooledThreadExecutor(size_t poolSize, OverflowPolicy overflowPolicy = OverflowPolicy::QUEUE_TASKS_EVENLY_ACCROSS_THREADS);
84+
PooledThreadExecutor(size_t poolSize, OverflowPolicy overflowPolicy = OverflowPolicy::QUEUE_TASKS_EVENLY_ACROSS_THREADS);
8585
~PooledThreadExecutor();
8686

8787
/**

‎aws-cpp-sdk-core/source/auth/AWSCredentialsProvider.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ AWSCredentials InstanceProfileCredentialsProvider::GetAWSCredentials()
251251

252252
void InstanceProfileCredentialsProvider::Reload()
253253
{
254-
AWS_LOGSTREAM_INFO(INSTANCE_LOG_TAG, "Credentials have expired attempting to repull from EC2 Metadata Service.");
254+
AWS_LOGSTREAM_INFO(INSTANCE_LOG_TAG, "Credentials have expired attempting to re-pull from EC2 Metadata Service.");
255255
m_ec2MetadataConfigLoader->Load();
256256
AWSCredentialsProvider::Reload();
257257
}
@@ -311,7 +311,7 @@ bool TaskRoleCredentialsProvider::ExpiresSoon() const
311311

312312
void TaskRoleCredentialsProvider::Reload()
313313
{
314-
AWS_LOGSTREAM_INFO(TASK_ROLE_LOG_TAG, "Credentials have expired or will expire, attempting to repull from ECS IAM Service.");
314+
AWS_LOGSTREAM_INFO(TASK_ROLE_LOG_TAG, "Credentials have expired or will expire, attempting to re-pull from ECS IAM Service.");
315315

316316
auto credentialsStr = m_ecsCredentialsClient->GetECSCredentials();
317317
if (credentialsStr.empty()) return;

‎aws-cpp-sdk-core/source/auth/signer/AWSAuthV4Signer.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ bool AWSAuthV4Signer::SignRequestWithSigV4a(Aws::Http::HttpRequest& request, con
112112
}
113113
else
114114
{
115-
// The hash will be calculated from the payload during siging.
115+
// The hash will be calculated from the payload during signing.
116116
payloadHash = {};
117117
}
118118
}

‎aws-cpp-sdk-core/source/client/AWSClient.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -757,7 +757,7 @@ void AWSClient::AddContentBodyToRequest(const std::shared_ptr<Aws::Http::HttpReq
757757

758758
//If there is no body, we have a content length of 0
759759
//note: we also used to remove content-type, but S3 actually needs content-type on InitiateMultipartUpload and it isn't
760-
//forbiden by the spec. If we start getting weird errors related to this, make sure it isn't caused by this removal.
760+
//forbidden by the spec. If we start getting weird errors related to this, make sure it isn't caused by this removal.
761761
if (!body)
762762
{
763763
AWS_LOGSTREAM_TRACE(AWS_CLIENT_LOG_TAG, "No content body, content-length headers");

0 commit comments

Comments
 (0)