Merge pull request ClickHouse#26 from ClickHouse/fix-tsan-condvar-2

alexey-milovidov · web-flow · commit d5450d76abda · 2024-06-25T02:49:08.000+02:00
Fix TSan report around condvar in HostResolver (2)
diff --git a/src/aws-cpp-sdk-core/source/auth/GeneralHTTPCredentialsProvider.cpp b/src/aws-cpp-sdk-core/source/auth/GeneralHTTPCredentialsProvider.cpp
@@ -121,6 +121,7 @@ bool GeneralHTTPCredentialsProvider::ShouldCreateGeneralHTTPProvider(const Aws::
                 std::unique_lock<std::mutex> lock(hostResolverMutex);
                 shouldAllow = !addresses.empty();
                 hostResolved = true;
+                hostResolverCV.notify_one();
               }
               else
               {

Original file line number	Diff line number	Diff line change
`@@ -121,6 +121,7 @@ bool GeneralHTTPCredentialsProvider::ShouldCreateGeneralHTTPProvider(const Aws::`
`121`	`121`	`std::unique_lock<std::mutex> lock(hostResolverMutex);`
`122`	`122`	`shouldAllow = !addresses.empty();`
`123`	`123`	`hostResolved = true;`
	`124`	`+ hostResolverCV.notify_one();`
`124`	`125`	`}`
`125`	`126`	`else`
`126`	`127`	`{`