Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runStatus changes to COMPLETED before run finishes logging #107

Open
willr3 opened this issue Mar 19, 2018 · 1 comment
Open

runStatus changes to COMPLETED before run finishes logging #107

willr3 opened this issue Mar 19, 2018 · 1 comment

Comments

@willr3
Copy link
Contributor

willr3 commented Mar 19, 2018

The GenericBenchmark.start() changes runStates to Run.COMPLETED but there are still several run related steps that can log to the run log or potentially hang.
I do not see a runStatus to indicate the run is COMPLETED and all run logs are no longer active. I propose we either change where the run is marked COMPLETED or add a new status to indicate the run is no longer changing any of the artifacts.

@whitingjr
Copy link
Collaborator

whitingjr commented May 3, 2018

It looks like you are integrating with another piece of software. That hoovers up these artifacts after Faban has manage a run.
The obvious thing is to move the assignment and it's enclosing if block to line 326. Can you try testing that to see if that solves your problem? Then create a PR if it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants