refactor(template): utilize new GET /v1/templates/{id} endpoint for template and deployment detail #506
Conversation
ygrishajev
force-pushed
the
feature/template
branch
3 times, most recently
from
d3c6b21
to
6f931cb
Compare
…emplate and deployment detail refs #477
ygrishajev
force-pushed
the
feature/template
branch
from
6f931cb
to
bc893c6
Compare
|
|
||
| export default DeploymentDetailPage; | ||
| export const getServerSideProps = getValidatedServerSideProps(contextSchema, async ({ params }) => { | ||
| const remoteDeployTemplate = await services.template.findById(CI_CD_TEMPLATE_ID); |
There was a problem hiding this comment.
I don't think we necessarily need to have loaded on the server. Especially since it's for a specific feature (Git repo deploy) that not that many deployments have currently.
There was a problem hiding this comment.
looking into the logic in the components it seems like this template is still needed there. Perhaps this could be changed ofc.
But I was thinking of how often that template is changed? perhaps let's move it to static props and call it a day?
There was a problem hiding this comment.
Previously it was loaded through a hook,, but now it'll wait for the template to load to render the page. It should be fast enough that it doesn't affect the ux, but generally I'd put it as a fetch hook in the component.
This PR doesn't complete the issue, yes. So more is to come. May be I'll switch to some other outstanding things though. I was just pushing what's done. It's ready to merge though |
Ok sounds good! |
refs #477