Skip to content

The modal's overlay allows closing without an event #34

@jcalfee

Description

@jcalfee

Their is no way to detect when a user clicks away from the model (on the background) triggering it to close. The event happens here when it calls this.setState({open: false}):

https://github.com/akiran/react-foundation-apps/blob/master/src/modal/index.jsx#L35

  hideOverlay: function (e) {
    e.preventDefault();
    if (this.props.overlayClose) {
      this.setState({open: false});   
    }
  },

In our case, we can't use componentWillUnmount, we are using a global model that remains mounted the entire life of the app. When subscribed to the model ZfApi.subscribe(this.props.modalId, (name, msg) => { it would be ideal to see a "close" event issued for the overlayClose in addition to the X and Cancel.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions