Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Angular 16 #6009

Open
1 of 3 tasks
Yasmenmohamedali opened this issue Nov 27, 2023 · 11 comments
Open
1 of 3 tasks

Upgrade to Angular 16 #6009

Yasmenmohamedali opened this issue Nov 27, 2023 · 11 comments

Comments

@Yasmenmohamedali
Copy link

Yasmenmohamedali commented Nov 27, 2023

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request
  • question about the decisions made in the repository

Issue description

Current behavior:
I noticed that ngx-admin was upgraded to Angular 15 and not Angular 16 is there any reason that ngx-admin is not using Angular 16 or should we except the upgrade anytime soon? @denStrigo

Expected behavior:

Steps to reproduce:

Related code:

insert short code snippets here

Other information:

npm, node, OS, Browser

<!--
Node, npm: `node --version` and `npm --version`
OS: Windows (7/8/10). Linux (incl. distribution). macOS (El Capitan? Sierra?)
Browser: Chrome/Safari/Firefox/etc?
-->

Angular, Nebular

<!--
Check your `package-lock.json` or locate a `package.json` in the `node_modules` folder.
-->
@prusama
Copy link

prusama commented Dec 3, 2023

I would be happy too if this was upgraded to Angular 16.
Btw if you do not want to wait, I have temporary solution:

  1. Run ng update @angular/core@16 @angular/cli@16 --allow-dirty --force
  2. Downgrade ws dependency npm i @types/[email protected] --legacy-peer-deps otherwise compiler will get mad about generic type issue.
  3. Enjoy the ngx-admin with Angular 16.

@nikesh9220
Copy link

Yes, It would be great if we update it to Angular 16 and then 17.

@nook24
Copy link

nook24 commented Apr 3, 2024

Any news about adding support for Angular 17?
I mean, Angular 18 will be released in May I guess.

@PerryCodes
Copy link

Angular 18 is out. So this is now THREE versions out-of-date.

@koo9
Copy link

koo9 commented Oct 18, 2024

there are lots of legacy dependencies in the project, even with the latest release v11, they are still there. wonder if there are plans to bring all dependencies up to date.

@GiKyouGetsu
Copy link

there are lots of legacy dependencies in the project, even with the latest release v11, they are still there. wonder if there are plans to bring all dependencies up to date.

Can not agree more!!

@koo9
Copy link

koo9 commented Oct 24, 2024

release v11 from here still has the node-saas dependency issue when build, the way to get around it is to upgrade node-saas to saad (follow the instruction in this link here how to upgrade node-saas to saad, after upgrading saas, run npm install --legacy-peer-deps will install all dependencies properly then run npm start to test the admin console. V11 is using angular v15.2.10, so after that you can upgrade to the latest version if you will.

@GiKyouGetsu
Copy link

release v11 from here still has the node-saas dependency issue when build, the way to get around it is to upgrade node-saas to saad (follow the instruction in this link here how to upgrade node-saas to saad, after upgrading saas, run npm install --legacy-peer-deps will install all dependencies properly then run npm start to test the admin console. V11 is using angular v15.2.10, so after that you can upgrade to the latest version if you will.

After I upgrade to Angular 15, I get the build issue like below:
./src/app/@theme/styles/styles.scss?ngGlobalStyle:1:0 - Error: Module parse failed: Unexpected character '@' (1:0)
File was processed with these loaders:

  • ./node_modules/resolve-url-loader/index.js
  • ./node_modules/@angular-devkit/build-angular/node_modules/sass-loader/dist/cjs.js
    You may need an additional loader to handle the result of these loaders.

@charset "UTF-8";
| /*
| Declare variables before making them global.

So the v11 is not work for now, right ? there are some build issues

@koo9
Copy link

koo9 commented Oct 24, 2024

v11 is working for me after upgrading to saas.

@koo9
Copy link

koo9 commented Oct 24, 2024

release v11 from here still has the node-saas dependency issue when build, the way to get around it is to upgrade node-saas to saad (follow the instruction in this link here how to upgrade node-saas to saad, after upgrading saas, run npm install --legacy-peer-deps will install all dependencies properly then run npm start to test the admin console. V11 is using angular v15.2.10, so after that you can upgrade to the latest version if you will.

After I upgrade to Angular 15, I get the build issue like below: ./src/app/@theme/styles/styles.scss?ngGlobalStyle:1:0 - Error: Module parse failed: Unexpected character '@' (1:0) File was processed with these loaders:

  • ./node_modules/resolve-url-loader/index.js
  • ./node_modules/@angular-devkit/build-angular/node_modules/sass-loader/dist/cjs.js
    You may need an additional loader to handle the result of these loaders.

@charset "UTF-8";
| /*
| Declare variables before making them global.

So the v11 is not work for now, right ? there are some build issues

did you download v11 directly or you upgrade from other version?

@koo9
Copy link

koo9 commented Oct 25, 2024

if you follow the instructions in my comment, it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants
@PerryCodes @koo9 @nook24 @prusama @nikesh9220 @GiKyouGetsu @Yasmenmohamedali and others