Skip to content

Commit 93e70e2

Browse files
author
al1-ce
committed
readme, bugfix and reuse compliancy
1 parent 1a83798 commit 93e70e2

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

74 files changed

+1017
-66
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

+27
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
---
2+
name: Bug report
3+
about: Create a report to help us improve
4+
title: ''
5+
labels: bug
6+
assignees: ''
7+
8+
---
9+
10+
**Device info**
11+
- OS: [e.g. Arch Linux x64 or Windows x86]
12+
- Faux version: [e.g. v1.0.0]
13+
14+
**Describe the bug**
15+
A clear and concise description of what the bug is.
16+
17+
**Expected behavior**
18+
A clear and concise description of what you expected to happen.
19+
20+
**Screenshots**
21+
If applicable, add screenshots to help explain your problem.
22+
23+
**Additional context**
24+
Add any other context about the problem here.
25+
26+
**Minimal reproduction project**
27+
Most simple project that will allow to reproduce this bug
+20
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
---
2+
name: Feature request
3+
about: Suggest an idea for this project
4+
title: ''
5+
labels: enhancement
6+
assignees: ''
7+
8+
---
9+
10+
**Is your feature request related to a problem? Please describe.**
11+
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
12+
13+
**Describe the solution you'd like**
14+
A clear and concise description of what you want to happen.
15+
16+
**Describe alternatives you've considered**
17+
A clear and concise description of any alternative solutions or features you've considered.
18+
19+
**Additional context**
20+
Add any other context or screenshots about the feature request here.

.github/workflows/d.yml

+33
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
# This workflow uses actions that are not certified by GitHub.
2+
# They are provided by a third-party and are governed by
3+
# separate terms of service, privacy policy, and support
4+
# documentation.
5+
name: D
6+
7+
on:
8+
push:
9+
branches: [ "master" ]
10+
pull_request:
11+
branches: [ "master" ]
12+
13+
permissions:
14+
contents: read
15+
16+
jobs:
17+
build:
18+
19+
runs-on: ubuntu-latest
20+
21+
steps:
22+
- uses: actions/checkout@v3
23+
- uses: dlang-community/setup-dlang@4c99aa991ce7d19dd3064de0a4f2f6b2f152e2d7
24+
25+
- name: 'Build & Test'
26+
run: |
27+
# Build the project, with its main file included, without unittests
28+
dub build --compiler=$DC
29+
# Build and run tests, as defined by `unittest` configuration
30+
# In this mode, `mainSourceFile` is excluded and `version (unittest)` are included
31+
# See https://dub.pm/package-format-json.html#configurations
32+
dub test --compiler=$DC
33+

.github/workflows/reuse.yml

+11
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
name: REUSE Compliance Check
2+
3+
on: [push, pull_request]
4+
5+
jobs:
6+
test:
7+
runs-on: ubuntu-latest
8+
steps:
9+
- uses: actions/checkout@v4
10+
- name: REUSE Compliance Check
11+
uses: fsfe/reuse-action@v3

.pre-commit-config.yaml

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
repos:
2+
- repo: https://github.com/fsfe/reuse-tool
3+
rev: v1.0.0
4+
hooks:
5+
- id: reuse
6+

.reuse/dep5

+17
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
2+
Upstream-Name: sily
3+
Upstream-Contact: Alisa Lain <[email protected]>
4+
Source: https://github.com/al1-ce/sily
5+
6+
Files: test/* readme/*
7+
Copyright: (C) 2022 Alisa Lain <[email protected]>
8+
License: GPL-3.0-or-later
9+
10+
Files: .github/* dub.sdl .dub/* .gitignore .pre-commit-config.yaml
11+
Copyright: (C) 2022 Alisa Lain <[email protected]>
12+
License: CC0-1.0
13+
14+
Files: .todo.md AUTHORS.md CHANGEDLOG.md CONTRIBUTING.md README.md justfile
15+
Copyright: (C) 2022 Alisa Lain <[email protected]>
16+
License: CC0-1.0
17+

AUTHORS.md

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
[Alisa Lain aka al1-ce / silyneko](https://github.com/al1-ce)
2+

CONTRIBUTING.md

+150
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,150 @@
1+
# Contributing Guidelines
2+
3+
#### Bug reporting
4+
5+
Open an issue at [GitHub issue tracker](https://github.com/al1-ce/sily/issues). Before doing that, ensure the bug was not already reported or fixed in `master` branch. Describe a problem and, if necessary, provide minimal code needed to reproduce it.
6+
7+
#### Bug fixing
8+
9+
Open a new GitHub pull request with your patch. Provide a description of the problem and solution. Follow our [code style](#code-style-and-standards).
10+
11+
#### Implementing new features
12+
13+
New code should at least:
14+
* work under Windows and POSIX systems and provide platform-agnostic API
15+
* support x86 and x86_64 targets
16+
* not use any external dependencies or have them as optional dependencies
17+
* follow our [code style](#code-style-and-standards)
18+
* not violate copyright/licensing. When adapting third-party code, make sure that it is compatible with [GNU GPL 3.0](https://www.gnu.org/licenses/gpl-3.0.en.html).
19+
20+
#### Branching strategy
21+
22+
`master` branch is a development branch for the next release. When release is ready, `master` branch will be pushed into `release` branch and release will be made from it.
23+
24+
#### Code style and standards
25+
26+
Sily mostly follows [D style](https://dlang.org/dstyle.html). Essential rules are the following:
27+
* Use spaces instead of tabs. Each indentation level is 4 spaces
28+
* There's always a space after control statements (`if`, `while`, `for`, etc...)
29+
* Opening curly bracket should be on a **same** line
30+
* Functions and variables should be in `camelCase`
31+
* Classes, structs and enums should be in `PascalCase`
32+
* Module names should be in lowercase
33+
* `if () else if ()` can be split as `if () else\n if ()`
34+
* If method or function is used as property parenthesis can be dropped
35+
* Prefer explicitly importing methods instead of importing whole module when only several methods from this module are needed. Exception is when imported module declares only one thing (i.e vector and aliases for it)
36+
* Also prefer explicitly importing sub-modules. I.e `import std.algorithm.searching;` instead of `import std.algorithm;`
37+
* Imports are ordered separated by single space. First normal, then static and finally public:
38+
1. std
39+
2. core
40+
3. other libraries (with version specifier)
41+
4. sily
42+
* Preferred order of declarations for classes or structs is:
43+
1. Public properties and one-line setters/getters
44+
2. Private properties
45+
3. Constructors
46+
4. Public methods
47+
5. Private methods
48+
* Name prefixes are:
49+
- ` ` - none for any kind of properties except ones below (`public static const int normalProperty`)
50+
- `_` - for private/protected properties (`private int _privateProperty`)
51+
- `s_` - for private/protected static properties (`private static int s_staticInt`)
52+
- `t_` - for private/protected thread static properties (`private shared int t_staticInt`)
53+
- `_` - as postfix when name is a keyword (`bool bool_`)
54+
* Function signature preferred to be in order:
55+
1. attributes (@property)
56+
2. visibility (public, private...), `public` can be dropped since everything is default public
57+
3. isStatic (static)
58+
4. misc
59+
5. isOverride (override)
60+
6. type qualifiers and type (int, bool...)
61+
7. name and params
62+
8. attributes (const, nothrow, pure, @nogc, @safe)
63+
9. i.e `@property private static override int myMethod(int* ptr) @safe @nogc nothrow {}`
64+
* Interfaces must be prefixed with `I`, i.e. `IEntity`
65+
* When declaring properties, methods, etc... visibility modifier can be dropped in favor of global visibility modifier, i.e `private:`. This type of declaration is valid but should be avoided since it's considered implicit
66+
- Example:
67+
```
68+
class MyClass {
69+
public:
70+
int myPublicInt;
71+
string myPublicString;
72+
73+
private:
74+
int myPrivateInt;
75+
76+
public:
77+
int myPublicIntMethod() {}
78+
...
79+
}
80+
```
81+
* Always describe symbols with ddoc unless name is self-descriptive (for properties)
82+
* **Avoid exceptions at all costs.** Prefer status return checks and if needed to return nullable
83+
* Include copyright line at top of source file or in `.reuse/dep5` for resource files or meta files
84+
* Copyright line is subject to change!
85+
86+
Example of how a module would look like when adhering to those rules:
87+
```d
88+
// SPDX-FileCopyrightText: (C) 2022 Alisa Lain <[email protected]>
89+
// SPDX-License-Identifier: GPL-3.0-or-later
90+
91+
/++
92+
Custom sily module.
93+
Currently an example of style to use in sily source code.
94+
+/
95+
module sily.custom;
96+
97+
import std.stdio: stdout, stdin, writeln;
98+
99+
import core.stdc: FILE;
100+
101+
version (Have_clib) import clib.optional;
102+
103+
import sily.vector;
104+
import sily.term: isatty;
105+
106+
static import sily.tui;
107+
108+
public import sily.web;
109+
110+
/// Prints if std is a tty
111+
void funcName() {
112+
if (stdout.isatty) {
113+
trace("STDOUT is a tty");
114+
} else
115+
if (stdin.isatty) {
116+
trace("STDIN is a tty");
117+
} else {
118+
trace("None are tty")
119+
}
120+
}
121+
122+
/// CustomStruct isCustom type enum
123+
enum CustomEnum {
124+
enumKey1,
125+
enumKey2
126+
}
127+
128+
/// Structure to do custom things
129+
struct CustomStruct {
130+
/// Is custom struct
131+
CustomEnum isCustom;
132+
/// Struct index
133+
static int index;
134+
135+
private int _privateIndex;
136+
private shared bool t_isInit;
137+
138+
/// Returns private name
139+
@property string getName() const {
140+
return privateName();
141+
}
142+
143+
/// Ditto
144+
private string privateName() const {
145+
return "my private name";
146+
}
147+
}
148+
```
149+
150+

LICENSES/CC0-1.0.txt

+121
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,121 @@
1+
Creative Commons Legal Code
2+
3+
CC0 1.0 Universal
4+
5+
CREATIVE COMMONS CORPORATION IS NOT A LAW FIRM AND DOES NOT PROVIDE
6+
LEGAL SERVICES. DISTRIBUTION OF THIS DOCUMENT DOES NOT CREATE AN
7+
ATTORNEY-CLIENT RELATIONSHIP. CREATIVE COMMONS PROVIDES THIS
8+
INFORMATION ON AN "AS-IS" BASIS. CREATIVE COMMONS MAKES NO WARRANTIES
9+
REGARDING THE USE OF THIS DOCUMENT OR THE INFORMATION OR WORKS
10+
PROVIDED HEREUNDER, AND DISCLAIMS LIABILITY FOR DAMAGES RESULTING FROM
11+
THE USE OF THIS DOCUMENT OR THE INFORMATION OR WORKS PROVIDED
12+
HEREUNDER.
13+
14+
Statement of Purpose
15+
16+
The laws of most jurisdictions throughout the world automatically confer
17+
exclusive Copyright and Related Rights (defined below) upon the creator
18+
and subsequent owner(s) (each and all, an "owner") of an original work of
19+
authorship and/or a database (each, a "Work").
20+
21+
Certain owners wish to permanently relinquish those rights to a Work for
22+
the purpose of contributing to a commons of creative, cultural and
23+
scientific works ("Commons") that the public can reliably and without fear
24+
of later claims of infringement build upon, modify, incorporate in other
25+
works, reuse and redistribute as freely as possible in any form whatsoever
26+
and for any purposes, including without limitation commercial purposes.
27+
These owners may contribute to the Commons to promote the ideal of a free
28+
culture and the further production of creative, cultural and scientific
29+
works, or to gain reputation or greater distribution for their Work in
30+
part through the use and efforts of others.
31+
32+
For these and/or other purposes and motivations, and without any
33+
expectation of additional consideration or compensation, the person
34+
associating CC0 with a Work (the "Affirmer"), to the extent that he or she
35+
is an owner of Copyright and Related Rights in the Work, voluntarily
36+
elects to apply CC0 to the Work and publicly distribute the Work under its
37+
terms, with knowledge of his or her Copyright and Related Rights in the
38+
Work and the meaning and intended legal effect of CC0 on those rights.
39+
40+
1. Copyright and Related Rights. A Work made available under CC0 may be
41+
protected by copyright and related or neighboring rights ("Copyright and
42+
Related Rights"). Copyright and Related Rights include, but are not
43+
limited to, the following:
44+
45+
i. the right to reproduce, adapt, distribute, perform, display,
46+
communicate, and translate a Work;
47+
ii. moral rights retained by the original author(s) and/or performer(s);
48+
iii. publicity and privacy rights pertaining to a person's image or
49+
likeness depicted in a Work;
50+
iv. rights protecting against unfair competition in regards to a Work,
51+
subject to the limitations in paragraph 4(a), below;
52+
v. rights protecting the extraction, dissemination, use and reuse of data
53+
in a Work;
54+
vi. database rights (such as those arising under Directive 96/9/EC of the
55+
European Parliament and of the Council of 11 March 1996 on the legal
56+
protection of databases, and under any national implementation
57+
thereof, including any amended or successor version of such
58+
directive); and
59+
vii. other similar, equivalent or corresponding rights throughout the
60+
world based on applicable law or treaty, and any national
61+
implementations thereof.
62+
63+
2. Waiver. To the greatest extent permitted by, but not in contravention
64+
of, applicable law, Affirmer hereby overtly, fully, permanently,
65+
irrevocably and unconditionally waives, abandons, and surrenders all of
66+
Affirmer's Copyright and Related Rights and associated claims and causes
67+
of action, whether now known or unknown (including existing as well as
68+
future claims and causes of action), in the Work (i) in all territories
69+
worldwide, (ii) for the maximum duration provided by applicable law or
70+
treaty (including future time extensions), (iii) in any current or future
71+
medium and for any number of copies, and (iv) for any purpose whatsoever,
72+
including without limitation commercial, advertising or promotional
73+
purposes (the "Waiver"). Affirmer makes the Waiver for the benefit of each
74+
member of the public at large and to the detriment of Affirmer's heirs and
75+
successors, fully intending that such Waiver shall not be subject to
76+
revocation, rescission, cancellation, termination, or any other legal or
77+
equitable action to disrupt the quiet enjoyment of the Work by the public
78+
as contemplated by Affirmer's express Statement of Purpose.
79+
80+
3. Public License Fallback. Should any part of the Waiver for any reason
81+
be judged legally invalid or ineffective under applicable law, then the
82+
Waiver shall be preserved to the maximum extent permitted taking into
83+
account Affirmer's express Statement of Purpose. In addition, to the
84+
extent the Waiver is so judged Affirmer hereby grants to each affected
85+
person a royalty-free, non transferable, non sublicensable, non exclusive,
86+
irrevocable and unconditional license to exercise Affirmer's Copyright and
87+
Related Rights in the Work (i) in all territories worldwide, (ii) for the
88+
maximum duration provided by applicable law or treaty (including future
89+
time extensions), (iii) in any current or future medium and for any number
90+
of copies, and (iv) for any purpose whatsoever, including without
91+
limitation commercial, advertising or promotional purposes (the
92+
"License"). The License shall be deemed effective as of the date CC0 was
93+
applied by Affirmer to the Work. Should any part of the License for any
94+
reason be judged legally invalid or ineffective under applicable law, such
95+
partial invalidity or ineffectiveness shall not invalidate the remainder
96+
of the License, and in such case Affirmer hereby affirms that he or she
97+
will not (i) exercise any of his or her remaining Copyright and Related
98+
Rights in the Work or (ii) assert any associated claims and causes of
99+
action with respect to the Work, in either case contrary to Affirmer's
100+
express Statement of Purpose.
101+
102+
4. Limitations and Disclaimers.
103+
104+
a. No trademark or patent rights held by Affirmer are waived, abandoned,
105+
surrendered, licensed or otherwise affected by this document.
106+
b. Affirmer offers the Work as-is and makes no representations or
107+
warranties of any kind concerning the Work, express, implied,
108+
statutory or otherwise, including without limitation warranties of
109+
title, merchantability, fitness for a particular purpose, non
110+
infringement, or the absence of latent or other defects, accuracy, or
111+
the present or absence of errors, whether or not discoverable, all to
112+
the greatest extent permissible under applicable law.
113+
c. Affirmer disclaims responsibility for clearing rights of other persons
114+
that may apply to the Work or any use thereof, including without
115+
limitation any person's Copyright and Related Rights in the Work.
116+
Further, Affirmer disclaims responsibility for obtaining any necessary
117+
consents, permissions or other rights required for any use of the
118+
Work.
119+
d. Affirmer understands and acknowledges that Creative Commons is not a
120+
party to this document and has no duty or obligation with respect to
121+
this CC0 or use of the Work.

0 commit comments

Comments
 (0)