Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a problem detecting subdomains #9

Open
RolfLorenz opened this issue Jun 18, 2019 · 1 comment
Open

There is a problem detecting subdomains #9

RolfLorenz opened this issue Jun 18, 2019 · 1 comment

Comments

@RolfLorenz
Copy link

country domains differ from normal domains

the rule to detect a subdomain is [subdomain] . [domain] . [TDL]

but country domains are [domain] . [SLD] . [country code]

The rule is misfiring on Country code second-level domain deteting domains as subdomains

@alambrec
Copy link
Owner

hi @RolfLorenz,
Thank you for detecting this problem.
Indeed, I hadn't thought about country code second-level like .co.uk ...
However, I have yet to find the solution to fix this issue, due to some specific cases (.vet.br or wiki.br) is complex to catch with a regex expression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants