-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Probably won't compile with GCC 10 on Linux (-fcommon
issue)
#14
Comments
Sorry, forgot to add the actual errors that I get:
|
dude, this is a browser from 1993, do you expect it to work on a modern computer? |
Fingers crossed @ThePlaneGuy45 |
@ThePlaneGuy45 Why should it not work? I recall that I managed to build a Linux binary just a few years ago. The only problem since is that libpng has changed in incompatible ways, but even that can be patched easily. |
@ThePlaneGuy45 Builds and runs fine once the CFLAGS setting is changed when building with gcc 10, so this is still working -- and why not? :D |
I can confirm with Ubuntu 22.04.1 LTS & gcc 11.3.0 (gcc version 11.3.0 (Ubuntu 11.3.0-1ubuntu1~22.04)) that -fcommon lets it build & run! |
Yes. Ubuntu Mate 22.04.3 with gcc 11.4.0. Works after adding -fcommon to CFLAGS. |
GCC 10 changed the default from
-fcommon
to-fno-common
:https://wiki.gentoo.org/wiki/Gcc_10_porting_notes/fno_common
I haven't tested this with your version of Mosaic, only with another fork (https://github.com/yotann/ncsa-mosaic -- because it has been ported to a newer version of libpng, see #8). IMO, it's more than likely that it affects your version as well (I don't see any relevant differences between the two) and wanted to let you know.
One blunt workaround is to add
-fcommon
:As the Gentoo wiki points out, though, this is not an ideal solution. It also outlines nicely what should be done instead.
The text was updated successfully, but these errors were encountered: