Corrections to HTMLamp.h #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTMLformat.c, HTMLtable.c: The Motif 2.x XmStringDraw can display UTF-8 characters. gui.c, gui-dialog.c: replace XmStringCreateSimple with XmStringCreateLocalized xresources.h: use ISO 10646-1 fonts
HTMLamp.h: more complete list of HTML 4 entities HTMLparse.c: replace an HTML entity &#nnn; or &name; by the appropriate UTF-8 sequence.
Remove commented out code Fix indentation ifdef debug fprintf's in HTMLparse.c
Synchronize with accepted patch for UTF-8 charset
HTFile.h: defined the macros HTFile.c: parse the .xz and .bz2 extensions HTMIME.c: partial treatment of MIME types associated with .xz and .bz2 files HTCompressed.c: comment that the code will return if the file is .bz2 or .xz
Calling shell scripts instead of the actual executable does not work
HTCompressed.c: Added some code to decompress bzip2 and xz compressed files xresources.h: added resources for bzip2 and xz decompression program prefs.[ch] : added some preferences for bunzip xz --decompress programs HTInit.c: use aplay to play sound files if on Linux
Add more convenient defaults in HTInit.c for linux (display for images; aplay for sound; mpv for video)
…ers. In HTMLamp.h, only the first character was retained, leading to incorrect display of entities such as ∼⃒ Pairs of Unicode characters have been replaced by a single character when possible. The other entities are commented out.
readPNG.c: replace png_set_dither with png_set_quantize Makefile.linux: add flag -lz muldefs to ldflags HTMLamp.h: correct definitions for NotSubset and NotSuperset HTML entities
|
I'm sorry for not having looked at this before, I honestly kind of forgot this existed. @alandipert, maybe you could just give commit rights to the submitter? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In libhtmlw/HTMLamp.h I had created the array AmpEscapes[] from a file entities.json from W3C. Looking at the warnings produced by the compilation of NCSA Mosaic, I have recently realized that some of the HTML entities like
⫋︀ corresponded to a pair of unicode characters. This was simply causing a warning from GCC about excess
data in the array definition. I have replaced some entities with single character codes, and commented out the ones for which I could not find a single character approximation. This eliminates the GCC warnings, and corrects some misrepresentations of a few entities.
Besides this change, the other changes are