Skip to content

Commit 93271db

Browse files
authored
fix: improve types for EventEmitter (#60)
1 parent e10de7d commit 93271db

File tree

4 files changed

+424
-611
lines changed

4 files changed

+424
-611
lines changed

ng-package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
{
22
"$schema": "./node_modules/ng-packagr/ng-package.schema.json",
3-
"allowedNonPeerDependencies": [
4-
"css-element-queries"
5-
],
63
"dest": "./release",
74
"lib": {
85
"entryFile": "src/public-api.ts",

package.json

Lines changed: 17 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -30,39 +30,37 @@
3030
"monaco-editor": ">=0.20.0"
3131
},
3232
"devDependencies": {
33-
"@1stg/app-config": "^2.0.0",
33+
"@1stg/app-config": "^2.1.0",
3434
"@1stg/tslint-config": "^2.0.0",
35-
"@angular-devkit/build-angular": "^12.0.1",
36-
"@angular/cli": "^12.0.1",
37-
"@angular/common": "^12.0.1",
38-
"@angular/compiler": "^12.0.1",
39-
"@angular/compiler-cli": "^12.0.1",
40-
"@angular/core": "^12.0.1",
41-
"@angular/forms": "^12.0.1",
42-
"@angular/platform-browser": "^12.0.1",
43-
"@angular/platform-browser-dynamic": "^12.0.1",
44-
"@storybook/addon-actions": "^6.3.0-alpha.39",
45-
"@storybook/addon-knobs": "^6.3.0-alpha.21",
35+
"@angular-devkit/build-angular": "^12.0.2",
36+
"@angular/cli": "^12.0.2",
37+
"@angular/common": "^12.0.2",
38+
"@angular/compiler": "^12.0.2",
39+
"@angular/compiler-cli": "^12.0.2",
40+
"@angular/core": "^12.0.2",
41+
"@angular/forms": "^12.0.2",
42+
"@angular/platform-browser": "^12.0.2",
43+
"@angular/platform-browser-dynamic": "^12.0.2",
44+
"@storybook/addon-actions": "^6.3.0-beta.2",
45+
"@storybook/addon-knobs": "^6.3.0-next.2",
4646
"@storybook/addon-postcss": "^2.0.0",
47-
"@storybook/angular": "^6.3.0-alpha.39",
48-
"@storybook/builder-webpack5": "^6.3.0-alpha.39",
49-
"@storybook/cli": "^6.3.0-alpha.39",
50-
"@storybook/manager-webpack5": "^6.3.0-alpha.39",
47+
"@storybook/angular": "^6.3.0-beta.2",
48+
"@storybook/builder-webpack5": "^6.3.0-beta.2",
49+
"@storybook/cli": "^6.3.0-beta.2",
50+
"@storybook/manager-webpack5": "^6.3.0-beta.2",
5151
"@types/lodash-es": "^4.17.4",
5252
"lodash-es": "^4.17.21",
5353
"monaco-editor": "^0.24.0",
5454
"monaco-editor-webpack-plugin": "^3.1.0",
5555
"monaco-yaml": "^2.5.1",
56-
"ng-packagr": "^12.0.0",
57-
"npm-run-all": "^4.1.5",
56+
"ng-packagr": "^12.0.2",
5857
"postcss": "^8.3.0",
5958
"rimraf": "^3.0.2",
6059
"rxjs": "^7.1.0",
6160
"standard-version": "^9.3.0",
6261
"ts-node": "^10.0.0",
6362
"tslib": "^2.2.0",
6463
"tslint": "^6.1.3",
65-
"yarn-deduplicate": "^3.1.0",
6664
"zone.js": "^0.11.4"
6765
},
6866
"resolutions": {

src/monaco-common-editor.component.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,13 @@ export abstract class MonacoCommonEditorComponent
5353
* Events emitted when monaco editor changed.
5454
*/
5555
@Output()
56-
editorChange = new EventEmitter();
56+
editorChange = new EventEmitter<MonacoEditor>();
5757

5858
/**
5959
* Events emitted when monaco editor blurs.
6060
*/
6161
@Output()
62-
editorBlur = new EventEmitter();
62+
editorBlur = new EventEmitter<void>();
6363

6464
/**
6565
* A helper ID to let the user to see the embedded monaco editor ID.
@@ -89,7 +89,7 @@ export abstract class MonacoCommonEditorComponent
8989

9090
// for MonacoDiffEditorComponent usage
9191
protected get rootEditor() {
92-
return this._rootEditor || this.editor;
92+
return this._rootEditor ?? this.editor;
9393
}
9494

9595
protected set rootEditor(editor) {

0 commit comments

Comments
 (0)