Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-running notebooks #10

Open
4 tasks done
IanHawke opened this issue Aug 15, 2019 · 3 comments
Open
4 tasks done

Non-running notebooks #10

IanHawke opened this issue Aug 15, 2019 · 3 comments

Comments

@IanHawke
Copy link
Contributor

IanHawke commented Aug 15, 2019

Linked to openjournals/jose-reviews#61 .

Having checked the "General" and "Prereqs" section, the following notebooks didn't run for me currently (Julia v 1.1, Mac):

@albi3ro
Copy link
Owner

albi3ro commented Aug 23, 2019

I did find some issues in "Time Evolution" that I fixed.
I didn't find any issues with "Imaginary Time Evolution", but I had gone through Time Evolution and had added FFTW (so now FFTW is in packages list).
Those two should work now. Let me know if they don't.

Going over "Atomic Orbitals", I realize it does generally have problems that I am now trying to fix. I originally used the package PyPlot.jl to plot with, then switched to Plots.jl. I changed the syntax, but I didn't change what I was doing or how I was using the package. I'm working on that now.

"Atomic Orbitals 2" used a confusing and now deprecated package GLVisualize.jl. I've just fully deleted it now.

@IanHawke
Copy link
Contributor Author

Those all work, thanks.

Here come the next lot:

  • https://github.com/albi3ro/M4/blob/master/Numerics_Prog/HDF5.ipynb : dump() returns nothing which causes println to break. If all println(dump(...)) lines are replaced with dump(...) it works for me. Note that it may make sense to split the cells so the close(fid) line is in a separate cell: this means the later cells can be run even if an earlier cell breaks. However, I'm not sure this is a good suggestion, as keeping it in the same cell implicitly emphasizes that close should be done ASAP.
  • https://github.com/albi3ro/M4/blob/master/Graduate/Chern-Number.ipynb : linspace is now range, needs using LinearAlgebra to get norm, and I think the Array definition syntax needs fixing in places.

I think this is it, in terms of getting the notebooks running.

@albi3ro
Copy link
Owner

albi3ro commented Sep 14, 2019

Just fixed the HDF problem.

Seems dump() no longer is a function, at least one I could find in the documentation .

Try the most recent version of Chern Number. I think I have range and the correct Array everywhere now, and am using abs2.() instead of norm().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants