Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Add support for ethersjs v6 #330

Open
robotoer opened this issue May 29, 2023 · 12 comments
Open

FR: Add support for ethersjs v6 #330

robotoer opened this issue May 29, 2023 · 12 comments
Labels
feature request New feature or request

Comments

@robotoer
Copy link

Is your feature request related to a problem? Please describe.
Usage of alchemy-sdk with ethers v6 does work due to updates to the provider structure

@robotoer robotoer added the feature request New feature or request label May 29, 2023
@thebrianchen
Copy link
Member

@robotoer Was there any particular feature in ethers v6 that you're looking to use?

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs

@thebrianchen
Copy link
Member

Leaving this PR open to gauge developer demand. If you are using ethers v6 and want the sdk to support it, please comment what features you're looking for from v6. Thanks!

@SohailKh
Copy link

@thebrianchen nextjs 14 and the alchemy sdk are currently unusable without this upgrade. See:

ethers-io/ethers.js#4469
and on this repo
#400

@thebrianchen
Copy link
Member

@SohailKh Would adding the option to pass in your own connectionInfo overrides to the underlying provider based on the issue in ethers thread help?

The reason we are not considering upgrading to ethers is v6 without sufficient developer demand is because it will a breaking change the to the alchemy SDK. Currently, ethers v5 has 5x more weekly downloads than v6. If there is a particular set of features that developers require from v6 that aren't supported in v5, we will re-prioritize. Thanks!

@tazous
Copy link

tazous commented Mar 13, 2024

Hello to the team and thank you for your work!!
As said above, ethers 5 is not usable with nextjs 14 ... We did the nextjs migration few months ago and there was no other way than migrating ethers from 5 to 6 in order to make them both working together.
If migration is not considered now, it might lead being stuck with a deprecated stack and make future migration even more painful...
I know ethers changed quite a lot of things between both versions (I have to go through it on my side) but it seems to be for the better... -> no more BigNumber to be used throughout the code if I have to pick one "randomly" ...

@jhubbardsf
Copy link

jhubbardsf commented Mar 27, 2024

@thebrianchen The main reason I've updated my apps to ethers.js v6 is the use of the native BigInt type over the BigNumber library used in ethers.js v5. There's not really any new functionality I need from ethers.js v6 aside from that.

I realize the hesitation to update to v6 because of breaking changes but could it possibly be added an option instead? Some kind of flag when when creating your alchemy instance or something? In some of my apps I've installed ethers.js v6 alongside ethers.js v5 in a different namespace so that we can slowly migrate over (example below).

Package.json:

"ethers": "5.7.2",
"ethers-v6": "npm:[email protected]",
"ethers-v6,": "link:@typechain/ethers-v6,",

Code:

import { ...ethersV5Stuff } from 'ethers';
import { ...ethersV6Stuff } from 'ethers-v6';

Then you can have both in the same project easily and possibly slowly start supporting it. I'd love to be able to solely use the Alchemy SDK, but the lack of support for BigInt/EthersV6 is stopping that.

@Bookcliff
Copy link

@SohailKh Would adding the option to pass in your own connectionInfo overrides to the underlying provider based on the issue in ethers-io/ethers.js#4469 (comment) help?

Yes. Is that possible to do?

Copy link

github-actions bot commented May 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs

@thebrianchen
Copy link
Member

@SohailKh @Bookcliff I've added support for the ConnectionInfo override in v3.3.1. This should you workaround the error in #400 by passing your own AlchemySettings.connectionInfoOverrides option.

Copy link

github-actions bot commented Jun 8, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants