Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add resource files to Visual Studio solution files. #89

Closed
cristian64 opened this issue Nov 5, 2023 · 3 comments
Closed

Feature: Add resource files to Visual Studio solution files. #89

cristian64 opened this issue Nov 5, 2023 · 3 comments
Labels
good first issue

Comments

@cristian64
Copy link
Collaborator

The application logo was introduced in #84. However, the resource files were only set up for the CMake scripts. Equivalent changes to those to the CMakeLists.txt file need to be applied to the Dolphin-memory-engine.vcxproj file too.
@cristian64
Copy link
Collaborator Author

Since #112, the Visual Studio solution files have diverged a little further. It now also needs to link against the QtSvg component, and bundle the library (Qt6Svg[d].dll) and the SVG plug-in (qsvg[d].dll).

@cristian64
Copy link
Collaborator Author

Maintaining these platform-specific build files is a bit too cumbersome, in my opinion.

@dreamsyntax Thoughts on removing them?

@dreamsyntax
Copy link
Collaborator

I'd still rather keep them just for easy building locally without CMake.
It doesnt need to be up to date as artifacts built with VS will never be released

@cristian64 cristian64 mentioned this issue Jul 4, 2024
Merged
dreamsyntax added a commit that referenced this issue Jan 20, 2025
@dreamsyntax
Cleanup: Remove MSBuild / SLN
4e64704 
Resolve #89

Update README and gitignore; Commit custom debug build paths for CMake
VS
dreamsyntax added a commit that referenced this issue Jan 20, 2025
@dreamsyntax
Cleanup: Remove MSBuild / SLN
24dc86c 
Resolve #89

Update README and gitignore; Commit custom debug build paths for CMake
VS
@cristian64 cristian64 mentioned this issue Jan 21, 2025
Merged
dreamsyntax added a commit that referenced this issue Jan 21, 2025
@dreamsyntax
Cleanup: Remove MSBuild / SLN
da6e2fc 
Resolve #89

Update README and gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cristian64 @dreamsyntax