Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images relative to footer instead of relative to current page #4

Closed
applejag opened this issue Mar 3, 2021 · 1 comment
Closed
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@applejag
Copy link

applejag commented Mar 3, 2021

Is your feature request related to a problem? Please describe.
If I reference an image then the image link is going to be relative to whichever page I'm viewing.

Example:

<!-- same behaviour from all three samples: -->
![company logo](_images/logo.svg)
![company logo](/_images/logo.svg)
![company logo](/_images/logo.svg ':ignore')
On page it resolves to
example.com/#/ example.com/_images/logo.svg
example.com/#/some-dir/some-other-page example.com/some-dir/_images/logo.svg

Describe the solution you'd like
Don't know if it's possible, but if when resolving the URLs for the images for the footer if those all were based off the location of the _footer.md file. So if the footer customly changed to be at _docsify/footer.md, then the relative image URL logo.svg on example.com would look for the image at example.com/_docsify/logo.svg, no matter which markdown page is currently being viewed by Docsify.

Describe alternatives you've considered
Using absolute link to where we've hosted it. I.e. instead of the above example just using:

![company logo](https://example.com/_images/logo.svg)

But that makes it more difficult to work with the files locally.

@applejag applejag changed the title Images relative to docs root Images relative to footer instead of relative to current page Mar 3, 2021
@kosperera kosperera added the bug Something isn't working label Jun 5, 2021
@kosperera
Copy link
Member

kosperera commented Jun 5, 2021

@jilleJr The plugin uses docsify underneath to render markdown. You can get a faster response there.
Nevertheless, I think this is a known issue in docsifyjs.

Possible duplicate of:

@kosperera kosperera added the duplicate This issue or pull request already exists label Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants