Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display block missing in some classes #50

Open
bunglegrind opened this issue Aug 1, 2021 · 1 comment
Open

display block missing in some classes #50

bunglegrind opened this issue Aug 1, 2021 · 1 comment
Assignees
Labels

Comments

@bunglegrind
Copy link

If I convert the following url to a epub (save page):

https://overreacted.io/making-setinterval-declarative-with-react-hooks/

with the following custom css rules:

header h3,
.react-toggle,
main article header p,
footer,
aside
{display: none!important;}

body div div div div
{
  max-width: 90%!important;
} 

the display:block in class .gatsby-highlight-code-line is not present in the epub. leading to issues in visualization (as example please notice the first code box when "Your custom logic here" is written).

I'm using Firefox 90.0.2 on Windows.

@bunglegrind
Copy link
Author

It seems that adding "display" to the array supportedCss in

var supportedCss = [
fixes the issue

@alexadam alexadam added the bug label Aug 4, 2021
@alexadam alexadam self-assigned this Aug 4, 2021
bunglegrind added a commit to bunglegrind/save-as-ebook that referenced this issue Oct 1, 2021
bunglegrind added a commit to bunglegrind/save-as-ebook that referenced this issue Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants