diff --git a/.golangci.yml b/.golangci.yml index c92830b..f188b3a 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -13,7 +13,10 @@ linters-settings: disable-dec-order-check: false disable-init-func-first-check: false gci: - local-prefixes: github.com/alexandear/import-gitlab-commits + sections: + - standard + - default + - prefix(github.com/alexandear/import-gitlab-commits) goconst: min-len: 2 min-occurrences: 2 @@ -48,21 +51,11 @@ linters: enable-all: true disable: - depguard - - maligned - - exhaustivestruct - exhaustruct + - err113 - nonamedreturns - gomnd - - nosnakecase - - interfacer - - varcheck - - ifshort - - structcheck - - deadcode - - scopelint - - golint - rowserrcheck - wastedassign - - goerr113 - paralleltest - testpackage diff --git a/internal/gitlab.go b/internal/gitlab.go index 05c42b0..93bfcfc 100644 --- a/internal/gitlab.go +++ b/internal/gitlab.go @@ -130,9 +130,11 @@ func (s *GitLab) FetchCommits(ctx context.Context, user *User, projectID int, si ) ([]*Commit, error) { commits := make([]*Commit, 0, maxCommits) + const commitsPerPage = 100 + page := 1 for page > 0 { - cms, nextPage, err := s.fetchCommitPage(ctx, user, page, 100, since, projectID) + cms, nextPage, err := s.fetchCommitPage(ctx, user, page, commitsPerPage, since, projectID) if err != nil { return nil, fmt.Errorf("fetch one commit page: %w", err) }