Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genereting empty SVGS #4

Open
tomasz-rekawek-tb opened this issue Nov 6, 2019 · 2 comments
Open

Genereting empty SVGS #4

tomasz-rekawek-tb opened this issue Nov 6, 2019 · 2 comments

Comments

@tomasz-rekawek-tb
Copy link

Tested this on 30 png's sprite all of them genereted empty svg

@alexander-daniel
Copy link
Owner

@tomasz-rekawek-tb Thanks for the report!

Just curious if you could post one of the png images here so I can test it locally on my machine. At the same time, please let me know what version of node you're currently using and i'll do my best to re-create the issue.

I haven't used this module in a few years but I'd be happy to investigate and see if we can figure out what's going wrong!

@wlwl2
Copy link

wlwl2 commented May 27, 2020

This happens in the case when the PNG image is entirely in black (rgba(0, 0, 0, 255)).

This shows an empty SVG (black color):

Black

This shows the correct SVG (grey color):

Grey

I tested on an older version of Node.js. The version doesn't seem to matter (although I might be wrong).

By the way, thanks for creating this package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants