Skip to content

Commit 84eca22

Browse files
SteveMacenskialexanderjyuen
authored andcommitted
adding twist to twist stamped migration info (ros-navigation#614)
Signed-off-by: Steve Macenski <[email protected]>
1 parent 4e60b79 commit 84eca22

File tree

7 files changed

+34
-12
lines changed

7 files changed

+34
-12
lines changed

configuration/packages/collision_monitor/configuring-collision-monitor-node.rst

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,12 +200,13 @@ Parameters
200200
============== =============================
201201
Type Default
202202
-------------- -----------------------------
203-
bool false
203+
bool true
204204
============== =============================
205205

206206
Description
207207
Whether to use geometry_msgs::msg::Twist or geometry_msgs::msg::TwistStamped velocity data.
208208
True uses TwistStamped, false uses Twist.
209+
Note: This parameter is default ``false`` in Jazzy or older! Kilted or newer uses ``TwistStamped`` by default.
209210

210211
Polygons parameters
211212
===================
@@ -608,7 +609,7 @@ Here is an example of configuration YAML for the Collision Monitor.
608609
source_timeout: 5.0
609610
base_shift_correction: True
610611
stop_pub_timeout: 2.0
611-
enable_stamped_cmd_vel: False
612+
enable_stamped_cmd_vel: True # False for Jazzy or older
612613
use_realtime_priority: false
613614
polygons: ["PolygonStop", "PolygonSlow", "FootprintApproach"]
614615
PolygonStop:

configuration/packages/configuring-behavior-server.rst

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -233,12 +233,13 @@ Spin distance is given from the action request
233233
============== =============================
234234
Type Default
235235
-------------- -----------------------------
236-
bool false
236+
bool true
237237
============== =============================
238238

239239
Description
240240
Whether to use geometry_msgs::msg::Twist or geometry_msgs::msg::TwistStamped velocity data.
241241
True uses TwistStamped, false uses Twist.
242+
Note: This parameter is default ``false`` in Jazzy or older! Kilted or newer uses ``TwistStamped`` by default.
242243

243244

244245
BackUp Behavior Parameters
@@ -262,12 +263,13 @@ Backup distance, speed and time_allowance is given from the action request.
262263
============== =============================
263264
Type Default
264265
-------------- -----------------------------
265-
bool false
266+
bool true
266267
============== =============================
267268

268269
Description
269270
Whether to use geometry_msgs::msg::Twist or geometry_msgs::msg::TwistStamped velocity data.
270271
True uses TwistStamped, false uses Twist.
272+
Note: This parameter is default ``false`` in Jazzy or older! Kilted or newer uses ``TwistStamped`` by default.
271273

272274
DriveOnHeading Behavior Parameters
273275
**********************************
@@ -290,12 +292,13 @@ DriveOnHeading distance, speed and time_allowance is given from the action reque
290292
============== =============================
291293
Type Default
292294
-------------- -----------------------------
293-
bool false
295+
bool true
294296
============== =============================
295297

296298
Description
297299
Whether to use geometry_msgs::msg::Twist or geometry_msgs::msg::TwistStamped velocity data.
298300
True uses TwistStamped, false uses Twist.
301+
Note: This parameter is default ``false`` in Jazzy or older! Kilted or newer uses ``TwistStamped`` by default.
299302

300303
:bond_heartbeat_period:
301304

@@ -351,12 +354,13 @@ AssistedTeleop time_allowance is given in the action request
351354
============== =============================
352355
Type Default
353356
-------------- -----------------------------
354-
bool false
357+
bool true
355358
============== =============================
356359

357360
Description
358361
Whether to use geometry_msgs::msg::Twist or geometry_msgs::msg::TwistStamped velocity data.
359362
True uses TwistStamped, false uses Twist.
363+
Note: This parameter is default ``false`` in Jazzy or older! Kilted or newer uses ``TwistStamped`` by default.
360364

361365
Example
362366
*******
@@ -388,4 +392,4 @@ Example
388392
max_rotational_vel: 1.0
389393
min_rotational_vel: 0.4
390394
rotational_acc_lim: 3.2
391-
enable_stamped_cmd_vel: false
395+
enable_stamped_cmd_vel: true # default false in Jazzy or older

configuration/packages/configuring-controller-server.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,12 +210,13 @@ Parameters
210210
============== =============================
211211
Type Default
212212
-------------- -----------------------------
213-
bool false
213+
bool true
214214
============== =============================
215215

216216
Description
217217
Whether to use geometry_msgs::msg::Twist or geometry_msgs::msg::TwistStamped velocity data.
218218
True uses TwistStamped, false uses Twist.
219+
Note: This parameter is default ``false`` in Jazzy or older! Kilted or newer uses ``TwistStamped`` by default.
219220

220221
:bond_heartbeat_period:
221222

configuration/packages/configuring-loopback-sim.rst

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,12 @@ Parameters
7474
============== ==============
7575
Type Default
7676
-------------- --------------
77-
string false
77+
string True
7878
============== ==============
7979

8080
Description
81-
Whether cmd_vel is stamped or unstamped (i.e. Twist or TwistStamped)
81+
Whether cmd_vel is stamped or unstamped (i.e. Twist or TwistStamped).
82+
Note: This parameter is default ``false`` in Jazzy or older! Kilted or newer uses ``TwistStamped`` by default.
8283

8384
:scan_publish_dur:
8485

configuration/packages/configuring-velocity-smoother.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,12 +153,13 @@ Velocity Smoother Parameters
153153
============== =============================
154154
Type Default
155155
-------------- -----------------------------
156-
bool false
156+
bool true
157157
============== =============================
158158

159159
Description
160160
Whether to use geometry_msgs::msg::Twist or geometry_msgs::msg::TwistStamped velocity data.
161161
True uses TwistStamped, false uses Twist.
162+
Note: This parameter is default ``false`` in Jazzy or older! Kilted or newer uses ``TwistStamped`` by default.
162163

163164
:bond_heartbeat_period:
164165

migration/Jazzy.rst

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,20 @@ Jazzy to K-Turtle
55

66
Moving from ROS 2 Jazzy to K-Turtle, a number of stability improvements were added that we will not specifically address here.
77

8+
TwistStamped Default CmdVel Change
9+
**********************************
10+
11+
In Kilted and newer, the default ``cmd_vel`` topic for all ``Twist`` publishers and subscriptions is changed to ``TwistStamped`` in order to enable a broader range of applications.
12+
it also allows for rejection of stale velocity messages, which can be useful in some applications.
13+
Your robot should now subscribe to a ``TwistStamped`` message instead of a ``Twist`` message & update your simulation appropriately.
14+
The topic names are the same.
15+
16+
However, this can be disabled by setting ``enable_twist_stamped`` to ``false`` in the ``nav2_params.yaml`` file for all nodes that involve Twist subscriptions or publications.
17+
See the configuration guide for more information on how to configure this parameter for each node.
18+
19+
An example simulation migration using Gazebo can be seen in the `following pull request for the Turtlebot 3 and 4 <https://github.com/ros-navigation/nav2_minimal_turtlebot_simulation/pull/16>`_.
20+
21+
822
New Nav2 Loopback Simulator
923
***************************
1024

tutorials/docs/using_collision_monitor.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ The whole ``nav2_collision_monitor/params/collision_monitor_params.yaml`` file i
8787
transform_tolerance: 0.5
8888
source_timeout: 5.0
8989
stop_pub_timeout: 2.0
90-
enable_stamped_cmd_vel: False
90+
enable_stamped_cmd_vel: True # False for Jazzy or older by default
9191
polygons: ["PolygonStop", "PolygonSlow"]
9292
PolygonStop:
9393
type: "polygon"

0 commit comments

Comments
 (0)