Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out Enums #297

Open
bhatiarohan01 opened this issue Mar 4, 2022 · 1 comment
Open

Separate out Enums #297

bhatiarohan01 opened this issue Mar 4, 2022 · 1 comment

Comments

@bhatiarohan01
Copy link

Is your feature request related to a problem? Please describe.
It will be much cleaner and helpful if we can separate out the enum classes from the BaseClient class.
The benefits are 1\ much cleaner code when you make the function call. 2\ SOC. 3\ when building wrappers client object can be hidden, otherwise always have to create hooks to expose the client.

Describe the solution you'd like
Separate out Enums in a different file and import it.

Describe alternatives you've considered
None
Additional context
I have done the separation in my local environment and tested that client. I can contribute if you think this is reasonable.

@pssolanki111
Copy link
Contributor

+1

@bhatiarohan01 I'd be interested in the idea. Please share the local structure you have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants